Page MenuHomeFreeBSD

Fix the Ethernet+WiFi example
ClosedPublic

Authored by pauamma_gundo.com on Dec 6 2019, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:44 AM
Unknown Object (File)
Nov 11 2023, 8:15 PM
Unknown Object (File)
Oct 21 2023, 10:45 AM
Unknown Object (File)
Oct 10 2023, 7:10 PM
Unknown Object (File)
Sep 18 2023, 11:09 PM
Unknown Object (File)
Aug 28 2023, 12:16 PM
Unknown Object (File)
Jul 2 2023, 1:45 AM
Unknown Object (File)
Apr 27 2023, 2:14 PM
Subscribers

Details

Summary

Swap the procedure around to change the Ethernet interface address
instead of the wireless interface.

Change the Ethernet and wireless interface names and MAC addresses to
mine (re0 and ath0 instead of bge0 and iwn0).

Tweak some markup and wording while I'm here.

PR: 211436

Test Plan

Tested with lynx

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28011
Build 26169: arc lint + arc unit

Event Timeline

I do not have the technical understanding here.

Barring any typos that escaped my notice, looks fine to me. Thanks for your work on this!

This revision is now accepted and ready to land.Dec 15 2019, 3:18 PM
In D22708#499697, @jwb wrote:

Barring any typos that escaped my notice, looks fine to me. Thanks for your work on this!

Thanks for reviewing it. Now to wait for a committer, since I'm not one.

I'm currently only a ports committer, so this will have to fall on someone else.

crees added a subscriber: crees.

Please go ahead and commit with my approval.

Didn't know that was possible. I'm going to be swamped for the next week or two, but I'll look into it ASAP after that.

I'm trying to build-test per https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/overview.html and I'm getting nothing but '#' symbols for the text. Anybody seen this issue before?

In D22708#502624, @jwb wrote:

I'm trying to build-test per https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/overview.html and I'm getting nothing but '#' symbols for the text. Anybody seen this issue before?

During compilation or as the resulting text?
Do a "make clean" in the handbook's directory first to clean up all leftovers from previous runs, then run "make" again in that same dir (not in the subdir for the article).
Also, check the encoding of the patch, the patched file, and the result.

In the resulting text:

Part IV. Network Communication

. # ## ###

I already tried a make clean in the "handbook" directory and in "doc".

This occurs throughout the handbook, with or without the patch.

Only the PDF output is screwy and I can verify using the HTML, so I'll go ahead with the commit shortly. I made one small change, adding a note to inform the reader why we should change the Ethernet MAC rather than the WiFi:

<note>
  <para>In theory, either the Ethernet or wireless MAC address can
  be changed to match the other.  However, some popular wireless
  interfaces lack support for overriding the MAC address.  We
  therefore recommend overriding the Ethernet MAC address for this
  purpose.</para>
</note>

If there are no other suggestions, I'll proceed with the commit.

If the note is below the example, consider that approved as well (remember the blank line in between).

But the <para>'s text in the <note> need a bit more indentation. Other than that, it's good.

I actually put the note right after the statement it's clarifying:

<para>This is achieved by overriding the Ethernet interface's
  <acronym>MAC</acronym> address with that of the wireless
  interface.</para>

<note>
  <para>In theory, either the Ethernet or wireless MAC address can
    be changed to match the other.  However, some popular wireless
    interfaces lack support for overriding the MAC address.  We
    therefore recommend overriding the Ethernet MAC address for this
    purpose.</para>
</note>

<para>In this example, the Ethernet interface,
  <replaceable>re0</replaceable>, is the master and the
  wireless interface, <replaceable>wlan0</replaceable>, is
  the failover.  The <replaceable>wlan0</replaceable>

Good catch on the indentation.

This revision was automatically updated to reflect the committed changes.