Page MenuHomeFreeBSD
Differential D22639

bitset: avoid pessimized code when bitset size is not constant
ClosedPublic
Actions

Authored by rlibby on Dec 3 2019, 7:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 11:09 AM
Unknown Object (File)
Oct 17 2024, 1:02 PM
Unknown Object (File)
Oct 12 2024, 3:11 PM
Unknown Object (File)
Oct 11 2024, 2:51 PM
Unknown Object (File)
Oct 11 2024, 4:50 AM
Unknown Object (File)
Oct 10 2024, 10:06 PM
Unknown Object (File)
Oct 10 2024, 7:46 PM
Unknown Object (File)
Oct 5 2024, 8:44 PM
View All 43 Files
Subscribers
imp
jhb

Details

Reviewers
jeff
markj
Commits
rS355344: bitset: avoid pessimized code when bitset size is not constant
Summary

We have a couple optimizations for when the bitset is known to be just
one word. But with dynamically sized bitsets, it was actually more work
to determine the size than just to do the necessary computation. Now,
only use the optimization when the size is known to be constant.

Test Plan

kyua test -k /usr/tests/sys/Kyuafile

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27909
Build 26078: arc lint + arc unit

Event Timeline

rlibby created this revision.Dec 3 2019, 7:00 AM
Harbormaster completed remote builds in B27904: Diff 65151.Dec 3 2019, 7:00 AM
markj accepted this revision.Dec 3 2019, 3:53 PM
markj added inline comments.
sys/sys/bitset.h
37

I'd add a brief comment explaining why this is used.

This revision is now accepted and ready to land.Dec 3 2019, 3:53 PM
rlibby updated this revision to Diff 65162.Dec 3 2019, 4:36 PM

markj feedback: add a comment. Also, wrap a long line.

This revision now requires review to proceed.Dec 3 2019, 4:36 PM
Harbormaster completed remote builds in B27909: Diff 65162.Dec 3 2019, 4:36 PM
markj accepted this revision.Dec 3 2019, 4:45 PM
This revision is now accepted and ready to land.Dec 3 2019, 4:45 PM
Closed by commit rS355344: bitset: avoid pessimized code when bitset size is not constant (authored by rlibby). · Explain WhyDec 3 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.
rlibby added a commit: rS355344: bitset: avoid pessimized code when bitset size is not constant.
Herald added a subscriber: imp. · View Herald TranscriptDec 3 2019, 5:44 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
11 lines

Diff 65162

View Options

sys/sys/bitset.h

Loading...