devel/mdb: Use clang 7 as compiler on 11.x and 12.x to fix build.
ClosedPublic
Actions

Authored by jhb on Nov 21 2019, 7:07 PM.

Details

Reviewers

bdrewery

Commits

rP519627: MFH: r518116
rP518116: Use clang 7 as compiler on 11.x and 12.x to fix build.

Summary

clang 8 and later error for duplicate definitions of enum values. mdb
depends on having identical but duplicate definitions. This was fixed
differently in 13 with a change to the kernel, but that change is
disruptive and cannot be easily backported.

Test Plan

built on 13 (still used cc) and stable/11 (used clang70)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 27690
Build 25890: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 21 2019, 7:07 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 21 2019, 7:07 PM

Harbormaster completed remote builds in B27690: Diff 64686.Nov 21 2019, 7:07 PM

bdrewery accepted this revision.Nov 21 2019, 7:31 PM

This revision is now accepted and ready to land.Nov 21 2019, 7:31 PM

dch added a subscriber: dch.Nov 21 2019, 7:31 PM

dch added inline comments.

devel/mdb/Makefile
34	per IRC, guard this? `.if ${OPSYS} == FreeBSD && ..`

Closed by commit rP518116: Use clang 7 as compiler on 11.x and 12.x to fix build. (authored by jhb). · Explain WhyNov 21 2019, 10:22 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rP518116: Use clang 7 as compiler on 11.x and 12.x to fix build..

linimon retitled this revision from Use clang 7 as compiler on 11.x and 12.x to fix build. to devel/mdb: Use clang 7 as compiler on 11.x and 12.x to fix build..Nov 22 2019, 1:41 AM

jhb added a commit: rP519627: MFH: r518116.Dec 9 2019, 6:58 PM

Revision Contents
Changeset List

Path

Size

devel/

mdb/

Makefile

11 lines

Diff 64686

View Options

devel/mdb: Use clang 7 as compiler on 11.x and 12.x to fix build.ClosedPublicActions