Page MenuHomeFreeBSD
Differential D21875

Inconsistencies in DOF sections headers and sections
ClosedPublic
Actions

Authored by graeme.jenkinson_cl.cam.ac.uk on Oct 2 2019, 1:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 5:46 AM
Unknown Object (File)
Sat, Mar 23, 5:45 AM
Unknown Object (File)
Sat, Mar 23, 5:45 AM
Unknown Object (File)
Sat, Mar 23, 5:33 AM
Unknown Object (File)
Sat, Mar 23, 4:36 AM
Unknown Object (File)
Jan 31 2024, 10:02 AM
Unknown Object (File)
Jan 6 2024, 9:10 AM
Unknown Object (File)
Dec 20 2023, 2:18 AM
View All 31 Files
Subscribers
imp

Details

Reviewers
gnn
markj
domagoj.stolfa_gmail.com
Commits
rS354822: Fix inconsistencies in anonymous DOF files.
Summary

The DOF file output by dtrace -A contains only the loadable sections. However, as it was created by a call to dtrace_dof_create without flags, the original DOF was created with the loadable sections. The result is that the DOF includes the section headers for the unloadable sections (COMMENTS and UTSNAME) without these sections actually being present. This is inconsistent.

A simple change to anon_prog() in dtrace.c (cddl/contrib/opensolaris/cmd/dtrace) ensures that the missing sections are present in the outputted DOF. Alternatively, the call to dtrace_dof_create() could pass the DTRACE_D_STRIP flag stripping out the loadable sections. As the unloadable sections contain info useful for debugging purposes they haven't been stripped.

Test Plan

Tested change by created DOF - dtrace -A - and confirming that the missing sections are included in the resulting DOF and that the contain the correct information. Also confirmed that the other DOF sections remain valid.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

graeme.jenkinson_cl.cam.ac.uk created this revision.Oct 2 2019, 1:22 PM
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptOct 2 2019, 1:22 PM
Herald added a subscriber: imp. · View Herald Transcript
markj accepted this revision.Oct 2 2019, 5:02 PM

This makes sense to me, thanks. I'll commit it in a day or two if no one else jumps in.

graeme.jenkinson_cl.cam.ac.uk added a comment.Oct 2 2019, 6:29 PM
In D21875#477846, @markj wrote:

This makes sense to me, thanks. I'll commit it in a day or two if no one else jumps in.

Cool. It's only a minor thing but we are increasingly relying on correct knowledge of the internals of DIF and DOF to do our work on distribution.

markj added a comment.Oct 3 2019, 2:50 PM
In D21875#477890, @graeme.jenkinson_cl.cam.ac.uk wrote:
In D21875#477846, @markj wrote:

This makes sense to me, thanks. I'll commit it in a day or two if no one else jumps in.

Cool. It's only a minor thing but we are increasingly relying on correct knowledge of the internals of DIF and DOF to do our work on distribution.

Is there a "Sponsored by:" tag you'd like added to the commit message?

graeme.jenkinson_cl.cam.ac.uk added a comment.EditedOct 7 2019, 9:37 AM
In D21875#478050, @markj wrote:
In D21875#477890, @graeme.jenkinson_cl.cam.ac.uk wrote:
In D21875#477846, @markj wrote:

This makes sense to me, thanks. I'll commit it in a day or two if no one else jumps in.

Cool. It's only a minor thing but we are increasingly relying on correct knowledge of the internals of DIF and DOF to do our work on distribution.

Is there a "Sponsored by:" tag you'd like added to the commit message?

I'll just double check with Robert, I've just got a letter about contract extension. I think this is funded differently. Robert says DARPA/AFRL ATM, so some/all of the following blurb?

This software was developed by BAE Systems, the University of Cambridge Computer Laboratory, and Memorial University under DARPA/AFRL contract FA8650-15-C-7558 ("CADETS"), as part of the DARPA Transparent Computing (TC) research program.

Let me know if I should be putting this somewhere I couldn't see a way I can add this.

markj added a comment.Nov 10 2019, 3:45 PM
In D21875#478792, @graeme.jenkinson_cl.cam.ac.uk wrote:
In D21875#478050, @markj wrote:
In D21875#477890, @graeme.jenkinson_cl.cam.ac.uk wrote:
In D21875#477846, @markj wrote:

This makes sense to me, thanks. I'll commit it in a day or two if no one else jumps in.

Cool. It's only a minor thing but we are increasingly relying on correct knowledge of the internals of DIF and DOF to do our work on distribution.

Is there a "Sponsored by:" tag you'd like added to the commit message?

I'll just double check with Robert, I've just got a letter about contract extension. I think this is funded differently. Robert says DARPA/AFRL ATM, so some/all of the following blurb?

This software was developed by BAE Systems, the University of Cambridge Computer Laboratory, and Memorial University under DARPA/AFRL contract FA8650-15-C-7558 ("CADETS"), as part of the DARPA Transparent Computing (TC) research program.

Let me know if I should be putting this somewhere I couldn't see a way I can add this.

Sorry, I don't get a notification when you edit an existing message.

I believe we typically use "Sponsored by: DARPA/AFRL" in that case. There are many examples of this in the tree. I'll go ahead and commit with that tomorrow if you have no objection.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2019, 6:34 PM
Closed by commit rS354822: Fix inconsistencies in anonymous DOF files. (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS354822: Fix inconsistencies in anonymous DOF files..

Revision Contents
Changeset List

PathSize
head/
cddl/
contrib/
opensolaris/
cmd/
dtrace/
2 lines

Diff 64535

View Options

head/cddl/contrib/opensolaris/cmd/dtrace/dtrace.c

Loading...