Fix error found by new clang operator precendence warning
ClosedPublic
Actions

Authored by arichardson on Nov 17 2019, 5:27 PM.

Tags

None

Referenced Files

	F157004396: D22433.diff
	Sun, May 17, 10:06 PM

	F157003914: D22433.diff
	Sun, May 17, 10:02 PM

	Unknown Object (File)
	Fri, Apr 24, 4:01 PM

	Unknown Object (File)
	Thu, Apr 23, 8:05 AM

	Unknown Object (File)
	Mon, Apr 20, 8:03 AM

	Unknown Object (File)
	Mon, Apr 20, 1:24 AM

	Unknown Object (File)
	Apr 7 2026, 10:54 PM

	Unknown Object (File)
	Apr 6 2026, 4:10 PM

View All Files

Subscribers

imp

Details

Reviewers

• ian

Commits

rS360317: MFC r354796 (by arichardson):
rS354796: Fix error found by new clang operator precendence warning

Summary

error: operator '?:' has lower precedence than '|'; '|' will be evaluated first

I discovered this in CheriBSD after updating our fork of clang to the latest
upstream master.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27608
Build 25823: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 17 2019, 5:27 PM

Harbormaster completed remote builds in B27608: Diff 64501.Nov 17 2019, 5:27 PM

• ian accepted this revision.Nov 17 2019, 6:00 PM

This revision is now accepted and ready to land.Nov 17 2019, 6:00 PM

Closed by commit rS354796: Fix error found by new clang operator precendence warning (authored by arichardson). · Explain WhyNov 17 2019, 7:04 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS354796: Fix error found by new clang operator precendence warning.

Herald added a subscriber: imp. · View Herald TranscriptNov 17 2019, 7:04 PM

dim added a commit: rS360317: MFC r354796 (by arichardson):.Apr 25 2020, 3:46 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

i2c/

i2c.c

2 lines

Diff 64501

View Options

Fix error found by new clang operator precendence warningClosedPublicActions