Page MenuHomeFreeBSD

New port: x11/ly: TUI (ncurses-like) display manager for X and Wayland
ClosedPublic

Authored by 0mp on Nov 3 2019, 2:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 4:32 AM
Unknown Object (File)
Feb 8 2024, 7:34 PM
Unknown Object (File)
Jan 29 2024, 4:06 AM
Unknown Object (File)
Jan 29 2024, 4:06 AM
Unknown Object (File)
Jan 29 2024, 4:06 AM
Unknown Object (File)
Jan 29 2024, 4:06 AM
Unknown Object (File)
Jan 29 2024, 4:06 AM
Unknown Object (File)
Jan 29 2024, 4:06 AM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27494
Build 25726: arc lint + arc unit

Event Timeline

0mp edited the test plan for this revision. (Show Details)

Upload the final patch

Please test and review before it gets committed ;)

0mp retitled this revision from WIP: New port: x11/ly: TUI (ncurses-like) display manager for X and Wayland to New port: x11/ly: TUI (ncurses-like) display manager for X and Wayland.Nov 13 2019, 2:07 PM
0mp edited the summary of this revision. (Show Details)
0mp edited the test plan for this revision. (Show Details)

Your git submodule to gh_tuple looks interesting, it should probably be added to the framework and not to a specific port.

x11/ly/pkg-plist
4โ€“7

Unless those 4 files MUST NOT be modified, they should also use @sample.

  • Decorate setup files with @sample.
  • Do not set XDG_RUNTIME_DIR to /run/user/... as it is not supported like this

on FreeBSD and it is just much better to let programs use defaults (usually
somewhere in user's home directory). This unbreaks certain features of programs
like Firefox and GNOME Keyring.

x11/ly/Makefile
39โ€“50

No. This has to go as a post-patch target.
What you probably want to run is something along the lines of make clean extract do-patch makepatch. (YMMV)

Move REINPLACE_CMD invocations from pre-build to post-patch.

0mp marked an inline comment as done.Nov 13 2019, 3:38 PM
0mp added inline comments.
x11/ly/Makefile
39โ€“50

Nice trick. Thanks!

0mp marked an inline comment as done.Nov 13 2019, 4:19 PM
In D22228#488626, @mat wrote:

Your git submodule to gh_tuple looks interesting, it should probably be added to the framework and not to a specific port.

Thank you!

This is not so easy to generalize it. We would need to provide some hooks (like in case of this port, we need to run make github first).

This revision was not accepted when it landed; it landed in state Needs Review.Nov 15 2019, 3:04 PM
This revision was automatically updated to reflect the committed changes.