Page MenuHomeFreeBSD

New port: x11/ly: TUI (ncurses-like) display manager for X and Wayland
ClosedPublic

Authored by 0mp on Sun, Nov 3, 2:47 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

0mp created this revision.Sun, Nov 3, 2:47 PM
0mp edited the summary of this revision. (Show Details)Sun, Nov 3, 2:47 PM
0mp edited the summary of this revision. (Show Details)Tue, Nov 5, 3:09 PM
0mp edited the test plan for this revision. (Show Details)
0mp edited the summary of this revision. (Show Details)Fri, Nov 8, 3:50 PM
0mp edited the summary of this revision. (Show Details)Fri, Nov 8, 3:56 PM
0mp updated this revision to Diff 64256.Tue, Nov 12, 11:52 PM

Bring further fixes

0mp updated this revision to Diff 64273.Wed, Nov 13, 2:06 PM

Upload the final patch

Please test and review before it gets committed ;)

0mp retitled this revision from WIP: New port: x11/ly: TUI (ncurses-like) display manager for X and Wayland to New port: x11/ly: TUI (ncurses-like) display manager for X and Wayland.Wed, Nov 13, 2:07 PM
0mp edited the summary of this revision. (Show Details)
0mp edited the test plan for this revision. (Show Details)
mat added a comment.Wed, Nov 13, 2:21 PM

Your git submodule to gh_tuple looks interesting, it should probably be added to the framework and not to a specific port.

x11/ly/pkg-plist
3–6 ↗(On Diff #64273)

Unless those 4 files MUST NOT be modified, they should also use @sample.

0mp updated this revision to Diff 64274.Wed, Nov 13, 2:51 PM
  • Decorate setup files with @sample.
  • Do not set XDG_RUNTIME_DIR to /run/user/... as it is not supported like this

on FreeBSD and it is just much better to let programs use defaults (usually
somewhere in user's home directory). This unbreaks certain features of programs
like Firefox and GNOME Keyring.

mat added inline comments.Wed, Nov 13, 2:55 PM
x11/ly/Makefile
38–49 ↗(On Diff #64274)

No. This has to go as a post-patch target.
What you probably want to run is something along the lines of make clean extract do-patch makepatch. (YMMV)

0mp updated this revision to Diff 64275.Wed, Nov 13, 3:38 PM

Move REINPLACE_CMD invocations from pre-build to post-patch.

0mp marked an inline comment as done.Wed, Nov 13, 3:38 PM
0mp added inline comments.
x11/ly/Makefile
38–49 ↗(On Diff #64274)

Nice trick. Thanks!

0mp marked an inline comment as done.Wed, Nov 13, 4:19 PM
0mp added a comment.Thu, Nov 14, 5:36 PM
In D22228#488626, @mat wrote:

Your git submodule to gh_tuple looks interesting, it should probably be added to the framework and not to a specific port.

Thank you!

This is not so easy to generalize it. We would need to provide some hooks (like in case of this port, we need to run make github first).

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Nov 15, 3:04 PM
This revision was automatically updated to reflect the committed changes.