Page MenuHomeFreeBSD
Differential D22244

route: remove an outdated comment from rtrequest1_fib
Needs ReviewPublic
Actions

Authored by jacob.e.keller_intel.com on Nov 5 2019, 5:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 2, 3:27 AM
Unknown Object (File)
Thu, Jul 23, 11:44 PM
Unknown Object (File)
Jul 12 2026, 12:36 PM
Unknown Object (File)
Jun 17 2026, 7:18 PM
Unknown Object (File)
Jun 17 2026, 7:18 PM
Unknown Object (File)
May 21 2026, 2:17 AM
Unknown Object (File)
May 20 2026, 4:45 PM
Unknown Object (File)
May 15 2026, 8:25 AM
View All 97 Files
Subscribers
ae

Details

Reviewers
jhb
mmacy
erj
Summary

revision r334222 modified rtrequest1_fib to always take a reference on
the ifa structure. However, the comment above this indicates the code is
relying on a reference from rt_getifa_fib().

Since this is no longer the case, remove this outdated comment.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27358
Build 25608: arc lint + arc unit

Event Timeline

jacob.e.keller_intel.com created this revision.Nov 5 2019, 5:40 PM
Herald added a subscriber: ae. · View Herald TranscriptNov 5 2019, 5:40 PM
Harbormaster completed remote builds in B27358: Diff 63965.Nov 5 2019, 5:40 PM
jacob.e.keller_intel.com added reviewers: jhb, mmacy, erj.Nov 5 2019, 5:41 PM

I found this while debugging an extra reference on the ifa refcount. I think I found a "solution" that isn't quite right, but this comment is misleading.

Revision Contents
Changeset List

PathSize
sys/
net/
1 line

Diff 63965

View Options

sys/net/route.c

Loading...