Differential D21952

Remove adapters from t4_list earlier during detach.
ClosedPublic
Actions

Authored by jhb on Oct 9 2019, 12:24 AM.

Tags

None

Referenced Files

	F170103394: D21952.id.diff
	Thu, Sep 3, 12:46 PM

	F170090752: D21952.diff
	Thu, Sep 3, 11:51 AM

	Unknown Object (File)
	Tue, Sep 1, 12:53 PM

	Unknown Object (File)
	Tue, Sep 1, 12:42 PM

	Unknown Object (File)
	Tue, Sep 1, 12:31 PM

	Unknown Object (File)
	Tue, Sep 1, 12:07 PM

	Unknown Object (File)
	Mon, Aug 31, 3:59 PM

	Unknown Object (File)
	Sat, Aug 22, 8:59 PM

View All Files

Subscribers

imp

Details

Reviewers

Commits

rS353369: Remove adapters from t4_list earlier during detach.

Summary

This ensures the clip task won't race with t4_destroy_clip_table.

While here, make some mutex destroys unconditional since attach
always initializes them.

Test Plan

kldunload of if_cxgbe panicked due to the clip task racing with the clip table being destroyed
with this change and the fix for vmem_destroy, kldunload of if_cxgbe no longer panics

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 9 2019, 12:24 AM

Herald added a subscriber: ae. · View Herald TranscriptOct 9 2019, 12:24 AM

Harbormaster completed remote builds in B26944: Diff 63068.Oct 9 2019, 12:24 AM

np accepted this revision.Oct 9 2019, 7:18 PM

This revision is now accepted and ready to land.Oct 9 2019, 7:18 PM

Closed by commit rS353369: Remove adapters from t4_list earlier during detach. (authored by jhb). · Explain WhyOct 9 2019, 9:09 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS353369: Remove adapters from t4_list earlier during detach..

Herald added a subscriber: imp. · View Herald TranscriptOct 9 2019, 9:09 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

cxgbe/

t4_main.c

18 lines

Diff 63099

View Options

head/sys/dev/cxgbe/t4_main.c

Remove adapters from t4_list earlier during detach.ClosedPublicActions