Differential D21906

amd64: plug spurious cld instructions
ClosedPublic
Actions

Authored by mjg on Oct 5 2019, 5:12 PM.

Tags

None

Referenced Files

	F169898077: D21906.id.diff
	Wed, Sep 2, 10:05 PM

	Unknown Object (File)
	Tue, Sep 1, 9:29 AM

	Unknown Object (File)
	Tue, Sep 1, 3:57 AM

	Unknown Object (File)
	Mon, Aug 31, 10:21 PM

	Unknown Object (File)
	Mon, Aug 31, 7:26 PM

	Unknown Object (File)
	Mon, Aug 31, 2:27 PM

	Unknown Object (File)
	Mon, Aug 31, 7:59 AM

	Unknown Object (File)
	Mon, Aug 31, 3:49 AM

View All Files

Subscribers

imp

Details

Reviewers

kib

Commits

rS353327: amd64: plug spurious cld instructions

Summary

ABI already guarantees the direction is forward. Note this does not take care of i386-specific cld's.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mjg created this revision.Oct 5 2019, 5:12 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 5 2019, 5:12 PM

Harbormaster completed remote builds in B26887: Diff 62937.Oct 5 2019, 5:12 PM

Why did you left i386 out ?

I do not think it needs cld's as well, both ABI and actual exception/interrupt entry code clear IF.D both on i386 and amd64.

i386 has a lot of cld already and I have no means to test the removal. I can plug them from the places modified by this patch though.

drop cld for i386

mjg edited the summary of this revision. (Show Details)Oct 8 2019, 9:05 PM

kib accepted this revision.Oct 8 2019, 9:11 PM

This revision is now accepted and ready to land.Oct 8 2019, 9:11 PM

Closed by commit rS353327: amd64: plug spurious cld instructions (authored by mjg). · Explain WhyOct 8 2019, 9:14 PM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rS353327: amd64: plug spurious cld instructions.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

cpufunc.h

12 lines

x86/

include/

bus.h

18 lines

Diff 63054

View Options

sys/amd64/include/cpufunc.h