Page MenuHomeFreeBSD
Differential D21905

devfs: plug redundant bwillwrite avoidance
ClosedPublic
Actions

Authored by mjg on Oct 5 2019, 3:41 PM.
Tags
None
Referenced Files
F175281177: D21905.id62939.diff
Fri, Oct 9, 4:16 PM
F175281171: D21905.id62936.diff
Fri, Oct 9, 4:16 PM
F175276147: D21905.diff
Fri, Oct 9, 3:55 PM
Unknown Object (File)
Wed, Oct 7, 8:05 AM
Unknown Object (File)
Wed, Oct 7, 7:52 AM
Unknown Object (File)
Wed, Oct 7, 1:10 AM
Unknown Object (File)
Tue, Oct 6, 11:37 PM
Unknown Object (File)
Tue, Oct 6, 11:20 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS353126: devfs: plug redundant bwillwrite avoidance
Summary

vn_write already checks for vnode type to see if bwillwrite should be called.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.Oct 5 2019, 3:41 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 5 2019, 3:41 PM
Harbormaster completed remote builds in B26886: Diff 62936.Oct 5 2019, 3:41 PM
kib accepted this revision.Oct 5 2019, 5:08 PM

You may note that this is a revert of r244643, in the commit message.

I was sure that the problem was reported by pho, but apparently it was not.

This revision is now accepted and ready to land.Oct 5 2019, 5:08 PM
Closed by commit rS353126: devfs: plug redundant bwillwrite avoidance (authored by mjg). · Explain WhyOct 5 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS353126: devfs: plug redundant bwillwrite avoidance.

Revision Contents
Changeset List

PathSize
head/
sys/
fs/
devfs/
11 lines
kern/
3 lines
sys/
1 line

Diff 62939

View Options

head/sys/fs/devfs/devfs_vnops.c

Loading...
View Options

head/sys/kern/sys_generic.c

Loading...
View Options

head/sys/sys/file.h

Loading...