Fix locking for some RACK specific socket options
ClosedPublic
Actions

Authored by tuexen on Sep 27 2019, 7:45 PM.

Tags

None

Referenced Files

	F171058231: D21825.id62684.diff
	Tue, Sep 8, 11:10 AM

	Unknown Object (File)
	Mon, Sep 7, 7:02 PM

	Unknown Object (File)
	Mon, Sep 7, 2:15 PM

	Unknown Object (File)
	Sun, Sep 6, 9:37 AM

	Unknown Object (File)
	Sun, Sep 6, 4:37 AM

	Unknown Object (File)
	Sat, Sep 5, 4:07 PM

	Unknown Object (File)
	Sat, Sep 5, 9:48 AM

	Unknown Object (File)
	Sat, Sep 5, 3:03 AM

View All Files

Subscribers

imp

Details

Reviewers

rrs

Group Reviewers

transport

Commits

rS352842: Ensure that the INP lock is released before leaving [gs]etsockopt()

Summary

Ensure that the INP lock is released before leaving [gs]etsockopt() for RACK specific socket options.

These issues were found by a syzkaller instance.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 26743

Event Timeline

tuexen created this revision.Sep 27 2019, 7:45 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 27 2019, 7:45 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B26743: Diff 62665.Sep 27 2019, 7:45 PM

rrs accepted this revision.Sep 28 2019, 9:21 AM

This revision is now accepted and ready to land.Sep 28 2019, 9:21 AM

Closed by commit rS352842: Ensure that the INP lock is released before leaving [gs]etsockopt() (authored by tuexen). · Explain WhySep 28 2019, 1:05 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS352842: Ensure that the INP lock is released before leaving [gs]etsockopt().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack.c

13 lines

Diff 62665

View Options

sys/netinet/tcp_stacks/rack.c

Fix locking for some RACK specific socket optionsClosedPublicActions