remove obsolete i386 MD memchr implementation
ClosedPublic
Actions

Authored by emaste on Sep 25 2019, 1:59 PM.

Tags

None

Referenced Files

	F161370754: D21785.id.diff
	Fri, Jul 3, 5:35 AM

	Unknown Object (File)
	Thu, Jul 2, 7:52 PM

	Unknown Object (File)
	Wed, Jul 1, 8:47 AM

	Unknown Object (File)
	Fri, Jun 19, 3:39 PM

	Unknown Object (File)
	Thu, Jun 11, 12:11 PM

	Unknown Object (File)
	Jun 2 2026, 12:56 AM

	Unknown Object (File)
	Jun 1 2026, 8:33 PM

	Unknown Object (File)
	Apr 30 2026, 8:02 AM

View All Files

Subscribers

imp

Details

Reviewers

markj
kib

Commits

rS352689: remove obsolete i386 MD memchr implementation

Summary

bde reports:

This uses scasb, which was last optimal on the 8086, or perhaps the
original i386.  On freefall, it is several times slower than the
naive translation of the naive C code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Sep 25 2019, 1:59 PM

kib accepted this revision.Sep 25 2019, 2:35 PM

This revision is now accepted and ready to land.Sep 25 2019, 2:35 PM

markj accepted this revision.Sep 25 2019, 2:48 PM

Closed by commit rS352689: remove obsolete i386 MD memchr implementation (authored by emaste). · Explain WhySep 25 2019, 4:49 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS352689: remove obsolete i386 MD memchr implementation.

Herald added a subscriber: imp. · View Herald TranscriptSep 25 2019, 4:49 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

i386/

string/

Makefile.inc

1 line

memchr.S

61 lines

Diff 62551

View Options

head/lib/libc/i386/string/Makefile.inc