Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations.
ClosedPublic
Actions

Authored by markj on Sep 22 2019, 7:38 PM.

Details

Reviewers

Commits

rS352623: Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations.

Summary

This is necessary for accesses to DPCPU and VNET data variables in
PIC KLDs. This should have no functional impact for non-PIC KLDs since
such code shouldn't contain R_X86_64_RELATIVE relocations.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Sep 22 2019, 7:38 PM

Harbormaster completed remote builds in B26625: Diff 62433.Sep 22 2019, 7:38 PM

markj added a reviewer: kib.Sep 22 2019, 7:53 PM

How hard would be assert that lf is a dso, as opposed to an object file ?

In D21755#474725, @kib wrote:

How hard would be assert that lf is a dso, as opposed to an object file ?

It would be a bit of work: there is no field in the base linker_file which tells you the type of the file. It is of course trivial to add one though, so perhaps I should just do that and add the assert to elf_relocaddr().