Page MenuHomeFreeBSD

Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations.
ClosedPublic

Authored by markj on Sep 22 2019, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 6:36 AM
Unknown Object (File)
Fri, Sep 26, 5:11 PM
Unknown Object (File)
Wed, Sep 24, 11:04 AM
Unknown Object (File)
Tue, Sep 16, 2:11 PM
Unknown Object (File)
Tue, Sep 16, 6:26 AM
Unknown Object (File)
Aug 26 2025, 2:17 AM
Unknown Object (File)
Aug 3 2025, 6:49 AM
Unknown Object (File)
Aug 1 2025, 11:03 PM
Subscribers

Details

Summary

This is necessary for accesses to DPCPU and VNET data variables in
PIC KLDs. This should have no functional impact for non-PIC KLDs since
such code shouldn't contain R_X86_64_RELATIVE relocations.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

How hard would be assert that lf is a dso, as opposed to an object file ?

In D21755#474725, @kib wrote:

How hard would be assert that lf is a dso, as opposed to an object file ?

It would be a bit of work: there is no field in the base linker_file which tells you the type of the file. It is of course trivial to add one though, so perhaps I should just do that and add the assert to elf_relocaddr().

Add an assertion to elf_relocaddr(). This is a bit hacky but
hacky in the same way as linker_add_class().

This revision is now accepted and ready to land.Sep 22 2019, 9:07 PM