Page MenuHomeFreeBSD
Differential D21754

Set NX in mappings created by pmap_kenter() and pmap_kenter_attr().
ClosedPublic
Actions

Authored by markj on Sep 22 2019, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 12, 12:48 PM
Unknown Object (File)
Sat, Oct 10, 3:51 PM
Unknown Object (File)
Thu, Oct 8, 11:54 PM
Unknown Object (File)
Thu, Oct 8, 11:07 PM
Unknown Object (File)
Thu, Oct 8, 3:00 PM
Unknown Object (File)
Thu, Oct 8, 2:01 PM
Unknown Object (File)
Wed, Oct 7, 4:37 PM
Unknown Object (File)
Wed, Oct 7, 1:49 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rS352622: Set NX in mappings created by pmap_kenter() and pmap_kenter_attr().
Summary

As far as I know there is no reason for such mappings to be executable.
Other functions for creating kernel mappings, such as pmap_qenter(),
also set NX.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26624
Build 25001: arc lint + arc unit

Event Timeline

markj created this revision.Sep 22 2019, 7:38 PM
Harbormaster completed remote builds in B26624: Diff 62432.Sep 22 2019, 7:38 PM
markj added reviewers: alc, kib.Sep 22 2019, 7:53 PM
kib accepted this revision.Sep 22 2019, 8:16 PM

I think the only interesting case is pmap_mapbios(), but it should be fine. Anyway, we will see.

This revision is now accepted and ready to land.Sep 22 2019, 8:16 PM
alc accepted this revision.Sep 22 2019, 8:33 PM
Closed by commit rS352622: Set NX in mappings created by pmap_kenter() and pmap_kenter_attr(). (authored by markj). · Explain WhySep 23 2019, 2:12 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS352622: Set NX in mappings created by pmap_kenter() and pmap_kenter_attr()..
Herald added a subscriber: imp. · View Herald TranscriptSep 23 2019, 2:12 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
4 lines

Diff 62432

View Options

sys/amd64/amd64/pmap.c

Loading...