Differential D20677

Introduce quirks tunable for da driver
ClosedPublic
Actions

Authored by bevan_bi-co.net on Jun 17 2019, 7:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 4:25 AM

	Unknown Object (File)
	Sun, Dec 8, 9:42 PM

	Unknown Object (File)
	Wed, Dec 4, 10:56 AM

	Unknown Object (File)
	Fri, Nov 29, 2:12 PM

	Unknown Object (File)
	Sun, Nov 24, 12:01 PM

	Unknown Object (File)
	Tue, Nov 19, 6:22 PM

	Unknown Object (File)
	Nov 19 2024, 1:05 PM

	Unknown Object (File)
	Nov 19 2024, 12:43 PM

View All 46 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers

mav
imp

Commits

rS353584: MFC r352743: Add kern.cam.da.X.quirks tunable, similar existing for ada.
rS352743: Add kern.cam.da.X.quirks tunable, similar existing for ada.

Summary

Introduce a tunable kern.cam.da.X.quirks for devices handled by da, similar to that already existing for ada. This simplifies testing quirks for new devices as the kernel does not need to be recompiled.

I used this while trying to fix issues with a misbehaving drive. I don't know if this is something you may want to include, however I thought I'd post it here before it gets lost.

Test Plan

I tested this on FreeBSD 12.0-RELEASE and 13.0-CURRENT by adding the tunable to loader.conf, setting it to a combination of several quirks, and observing the kernel output when loading the corresponding device.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bevan_bi-co.net created this revision.Jun 17 2019, 7:41 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJun 17 2019, 7:41 PM

lwhsu added reviewers: mav, imp.Sep 17 2019, 8:24 PM

Generally I think it is good, but I think it should be set higher, after the "softc->quirks |= DA_Q_NO_6_BYTE;" line.

This revision now requires changes to proceed.Sep 17 2019, 10:04 PM

Thanks for the review! I agree it makes sense to move the code up so that other settings are derived accordingly.

mav accepted this revision.Sep 18 2019, 7:42 PM

This revision is now accepted and ready to land.Sep 18 2019, 7:42 PM

Closed by commit rS352743: Add kern.cam.da.X.quirks tunable, similar existing for ada. (authored by mav). · Explain WhySep 26 2019, 2:48 PM

This revision was automatically updated to reflect the committed changes.

mav added a commit: rS352743: Add kern.cam.da.X.quirks tunable, similar existing for ada..

mav added a commit: rS353584: MFC r352743: Add kern.cam.da.X.quirks tunable, similar existing for ada..Oct 15 2019, 6:47 PM

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

8 lines

Diff 62279

sys/cam/scsi/scsi_da.c

Loading...