Page MenuHomeFreeBSD

Introduce quirks tunable for da driver
ClosedPublic

Authored by bevan_bi-co.net on Jun 17 2019, 7:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 3:41 AM
Unknown Object (File)
Sat, Nov 16, 12:45 AM
Unknown Object (File)
Oct 3 2024, 5:16 AM
Unknown Object (File)
Sep 30 2024, 11:34 PM
Unknown Object (File)
Sep 21 2024, 11:00 PM
Unknown Object (File)
Sep 4 2024, 11:51 AM
Unknown Object (File)
Sep 4 2024, 11:51 AM
Unknown Object (File)
Sep 4 2024, 11:51 AM

Details

Summary

Introduce a tunable kern.cam.da.X.quirks for devices handled by da, similar to that already existing for ada. This simplifies testing quirks for new devices as the kernel does not need to be recompiled.

I used this while trying to fix issues with a misbehaving drive. I don't know if this is something you may want to include, however I thought I'd post it here before it gets lost.

Test Plan

I tested this on FreeBSD 12.0-RELEASE and 13.0-CURRENT by adding the tunable to loader.conf, setting it to a combination of several quirks, and observing the kernel output when loading the corresponding device.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mav requested changes to this revision.Sep 17 2019, 10:04 PM

Generally I think it is good, but I think it should be set higher, after the "softc->quirks |= DA_Q_NO_6_BYTE;" line.

This revision now requires changes to proceed.Sep 17 2019, 10:04 PM

Thanks for the review! I agree it makes sense to move the code up so that other settings are derived accordingly.

This revision is now accepted and ready to land.Sep 18 2019, 7:42 PM