fusefs: fix some minor issues with fuse_vnode_setparent
ClosedPublic
Actions

Authored by asomers on Sep 13 2019, 1:53 AM.

Details

Reviewers

emaste
cem

Commits

rS354161: MFC r352404, r352413-r352414
rS352404: fusefs: fix some minor issues with fuse_vnode_setparent

Summary

fusefs: fix some minor issues with fuse_vnode_setparent

When unparenting a vnode, actually clear the flag. AFAIK this is basically a no-op because we only unparent a vnode when reclaiming it or when unlinking.

There's no need to call fuse_vnode_setparent during reclaim, because we're about to free the vnode data anyway.

Test Plan

Ran the builtin test suite and pjdfstest

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26452
Build 24883: arc lint + arc unit

Event Timeline

asomers created this revision.Sep 13 2019, 1:53 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2019, 1:53 AM

Harbormaster completed remote builds in B26452: Diff 62016.Sep 13 2019, 1:54 AM

I'm not an expert here but seems reasonable.

This revision is now accepted and ready to land.Sep 16 2019, 1:53 PM

Closed by commit rS352404: fusefs: fix some minor issues with fuse_vnode_setparent (authored by asomers). · Explain WhySep 16 2019, 2:52 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS352404: fusefs: fix some minor issues with fuse_vnode_setparent.

asomers added a commit: rS354161: MFC r352404, r352413-r352414.Oct 30 2019, 1:35 AM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

fuse_node.h

2 lines

fuse_vnops.c

3 lines

Diff 62016

View Options

sys/fs/fuse/fuse_node.h