SIOCSIFNAME: Do nothing if we're not actually changing
ClosedPublic
Actions

Authored by kevans on Sep 12 2019, 3:01 PM.

Tags

None

Referenced Files

	F168333902: D21618.id61977.diff
	Thu, Aug 27, 4:14 PM

	Unknown Object (File)
	Wed, Aug 26, 5:35 PM

	Unknown Object (File)
	Wed, Aug 26, 7:50 AM

	Unknown Object (File)
	Tue, Aug 25, 7:36 PM

	Unknown Object (File)
	Tue, Aug 25, 4:58 PM

	Unknown Object (File)
	Tue, Aug 25, 4:23 PM

	Unknown Object (File)
	Tue, Aug 25, 7:42 AM

	Unknown Object (File)
	Tue, Aug 25, 2:30 AM

View All Files

Subscribers

imp

Details

Reviewers

brooks

Commits

rS352246: SIOCSIFNAME: Do nothing if we're not actually changing

Summary

Instead of throwing EEXIST, just succeed if the name isn't actually changing. We don't need to trigger departure or any of that because there's no change from consumers' perspective.

PR: 240539

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Sep 12 2019, 3:01 PM

Herald added subscribers: ae, imp. · View Herald TranscriptSep 12 2019, 3:01 PM

Harbormaster completed remote builds in B26424: Diff 61977.Sep 12 2019, 3:02 PM

kevans edited the summary of this revision. (Show Details)Sep 12 2019, 3:04 PM

LGTM.

This revision is now accepted and ready to land.Sep 12 2019, 3:21 PM

Closed by commit rS352246: SIOCSIFNAME: Do nothing if we're not actually changing (authored by kevans). · Explain WhySep 12 2019, 3:36 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rS352246: SIOCSIFNAME: Do nothing if we're not actually changing.

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if.c

2 lines

Diff 61980

View Options

SIOCSIFNAME: Do nothing if we're not actually changingClosedPublicActions