Differential D21437

Fix compilation of locore.S with clang
ClosedPublic
Actions

Authored by mhorne on Aug 27 2019, 2:04 PM.

Tags

None

Referenced Files

	F106145153: D21437.diff
	Thu, Dec 26, 3:37 AM

	Unknown Object (File)
	Mon, Dec 9, 5:08 PM

	Unknown Object (File)
	Nov 16 2024, 10:27 AM

	Unknown Object (File)
	Nov 5 2024, 9:28 AM

	Unknown Object (File)
	Oct 3 2024, 4:57 PM

	Unknown Object (File)
	Oct 2 2024, 4:01 AM

	Unknown Object (File)
	Sep 30 2024, 1:43 PM

	Unknown Object (File)
	Sep 30 2024, 4:24 AM

View All 58 Files

Subscribers

Details

Reviewers

br
markj

Commits

rS352036: Fix compilation of locore.S with clang

Summary

The branch from _start to mpentry has to cross a large section of data;
an offset larger than can be specified with a 12-bit branch immediate.
Fix this by converting the branch to an unconditional jump. The gcc
assembler does this conversion silently but is not done automatically by
clang.

Reported by: Jeremy Bennett <jeremy.bennett@embecosm.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Aug 27 2019, 2:04 PM

Harbormaster completed remote builds in B26136: Diff 61352.Aug 27 2019, 2:04 PM

markj added inline comments.Aug 27 2019, 2:22 PM

sys/riscv/riscv/locore.S
73 ↗	(On Diff #61352)	I would suggest adding a comment, since otherwise it looks like something that should be simplified.

markj accepted this revision.Aug 27 2019, 2:22 PM

This revision is now accepted and ready to land.Aug 27 2019, 2:22 PM

Add comment explaining the change

This revision now requires review to proceed.Sep 8 2019, 7:37 PM

Harbormaster completed remote builds in B26340: Diff 61809.Sep 8 2019, 7:37 PM

Approved.

This revision is now accepted and ready to land.Sep 8 2019, 7:48 PM

Closed by commit rS352036: Fix compilation of locore.S with clang (authored by mhorne). · Explain WhySep 8 2019, 7:53 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS352036: Fix compilation of locore.S with clang.

Herald added a subscriber: imp. · View Herald TranscriptSep 8 2019, 7:53 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

riscv/

10 lines

Diff 61814

head/sys/riscv/riscv/locore.S

Loading...