LinuxKPI: enable class dev_groups attributes
ClosedPublic
Actions

Authored by • hselasky on Sep 8 2019, 2:35 PM.

Details

Reviewers

imp
val_packett.cool
• hselasky

Group Reviewers

Contributor Reviews (src)

Commits

rS354616: MFC r354335:
rS354613: MFC r354335:
rS354335: Enable device class group attributes in the LinuxKPI.

Summary

This is necessary for backlight in DRM/KMS drivers:

% sysctl sys.class.backlight
sys.class.backlight.intel_backlight.bl_device.type: raw
sys.class.backlight.intel_backlight.bl_device.max_brightness: 65535
sys.class.backlight.intel_backlight.bl_device.actual_brightness: 5000
sys.class.backlight.intel_backlight.bl_device.brightness: 5000
sys.class.backlight.intel_backlight.bl_device.bl_power: 0

(the corresponding kms-drm patch is just removing the ifdef __linux__'es in linux_backlight.c. well, replacing them with a __FreeBSD_version check once this lands and gets a version number)

I think I've added the create_groups in the right place… it works, anyway :)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

val_packett.cool created this revision.Sep 8 2019, 2:35 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSep 8 2019, 2:35 PM

ping

Seems fine to me. Does this cause an issue for other users of LinuxKPI?

This revision is now accepted and ready to land.Sep 21 2019, 10:17 PM

I'll take it.

Found some bugs in the patch. Can you re-test? Also re-loading kernel module?

This revision now requires review to proceed.Sep 22 2019, 6:41 AM

Harbormaster completed remote builds in B26612: Diff 62411.Sep 22 2019, 6:41 AM

oh, i915 is reloadable, right. Everything works fine, can adjust brightness after reloading.

sys/compat/linuxkpi/common/include/linux/sysfs.h
64	why remove the comment? :)

This revision is now accepted and ready to land.Sep 22 2019, 11:57 AM

ping

Who will submit this patch?

In D21564#485874, @hselasky wrote:

Who will submit this patch?

I'm not sure what this means exactly? Submit to where? You mean listed as submitter in the commit message? Doesn't matter, you don't have to say it was me :D

I'll handle it.

Closed by commit rS354335: Enable device class group attributes in the LinuxKPI. (authored by • hselasky). · Explain WhyNov 4 2019, 2:19 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS354335: Enable device class group attributes in the LinuxKPI..

• hselasky added a commit: rS354613: MFC r354335:.Nov 11 2019, 2:56 PM

• hselasky added a commit: rS354616: MFC r354335:.Nov 11 2019, 3:28 PM