Differential D21557

fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode
ClosedPublic
Actions

Authored by asomers on Sep 6 2019, 10:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 18, 3:01 AM

	Unknown Object (File)
	Sat, May 11, 9:55 AM

	Unknown Object (File)
	Thu, May 2, 4:44 AM

	Unknown Object (File)
	Thu, Apr 25, 7:32 AM

	Unknown Object (File)
	Apr 19 2024, 9:17 AM

	Unknown Object (File)
	Apr 10 2024, 12:14 PM

	Unknown Object (File)
	Mar 28 2024, 9:22 PM

	Unknown Object (File)
	Jan 13 2024, 1:18 AM

View All 42 Files

Subscribers

Details

Reviewers

Commits

rS352230: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode

Summary

fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode

When communicating with a FUSE server that implements version 7.8
(or older) of the FUSE protocol, the FUSE_WRITE request structure is
16 bytes shorter than normal. The protocol version check wasn't
applied universally, leading to an extra 16 bytes being sent to such
servers. The extra bytes were allocated and bzero()d, so there was
no information disclosure.

MFC-With: r350665

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26326
Build 24804: arc lint + arc unit

Event Timeline

asomers created this revision.Sep 6 2019, 10:39 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2019, 10:39 PM

Harbormaster completed remote builds in B26326: Diff 61769.Sep 6 2019, 10:39 PM

emaste accepted this revision.Sep 10 2019, 8:07 PM

emaste added inline comments.

sys/fs/fuse/fuse_io.c
559	Probably put a blank line after the variable declaration

This revision is now accepted and ready to land.Sep 10 2019, 8:07 PM

Closed by commit rS352230: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode (authored by asomers). · Explain WhySep 11 2019, 7:29 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS352230: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode.

asomers mentioned this in rS352351: MFC the new fusefs driver.Sep 15 2019, 4:15 AM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

16 lines

tests/

sys/

fs/

fusefs/

14 lines

129 lines

Diff 61769

sys/fs/fuse/fuse_io.c

Loading...

tests/sys/fs/fusefs/mockfs.hh

Loading...

tests/sys/fs/fusefs/mockfs.cc

Loading...