Page MenuHomeFreeBSD

cpuset_setdomain(2): Ensure that the set is a subset of all_domains.
ClosedPublic

Authored by markj on Aug 30 2019, 8:24 PM.
Tags
None
Referenced Files
F106163764: D21477.diff
Thu, Dec 26, 10:49 AM
Unknown Object (File)
Sun, Dec 15, 3:58 AM
Unknown Object (File)
Sep 14 2024, 9:55 PM
Unknown Object (File)
Sep 12 2024, 1:02 AM
Unknown Object (File)
Sep 5 2024, 12:15 PM
Unknown Object (File)
Aug 11 2024, 11:50 PM
Unknown Object (File)
Aug 11 2024, 2:18 PM
Unknown Object (File)
Aug 11 2024, 4:12 AM
Subscribers

Details

Summary

Userspace is allowed to provide a mask of up to 256 bits. In the
kernel, the domain mask is 64 bits wide even though MAXMEMDOM is 8.
cpuset_setdomain() returns EINVAL if any bits beyond the first 64 are
set; go further and return an error if any bits outside of
all_domains are set.

domainset_empty_vm() assumes that the input set is a subset of
all_domains, since it iterates over the set and populates the ds_order
table. The problem became more noticeable after r351547.

We could instead silently mask off bits that are not present in
all_domains. However, since we already check for domain IDs >= 64
and return EINVAL if any are present, I don't see why we should
be inconsistent for domain IDs < 64.

Test Plan

Peter reported the bug and tested an earlier version of the patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable