Page MenuHomeFreeBSD

converters/lua-iconv: fix build on armv7
ClosedPublic

Authored by pkubaj on Aug 24 2019, 12:56 PM.
Tags
None
Referenced Files
F82768868: D21402.id61218.diff
Thu, May 2, 10:47 AM
F82768753: D21402.id.diff
Thu, May 2, 10:46 AM
F82764265: D21402.id61531.diff
Thu, May 2, 9:47 AM
F82761463: D21402.diff
Thu, May 2, 9:19 AM
Unknown Object (File)
Sat, Apr 27, 7:57 PM
Unknown Object (File)
Sat, Apr 27, 1:51 PM
Unknown Object (File)
Sat, Apr 20, 3:55 PM
Unknown Object (File)
Mar 22 2024, 2:33 PM

Details

Summary

armv7 requires -fPIC too.

PR: 239623

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Approved. IMHO there should also be an entry for armv6.

This revision is now accepted and ready to land.Aug 31 2019, 11:13 AM

Why isn't this just CFLAGS+=-fPIC ?

Because e.g. powerpc64 doesn't need it.

This revision was automatically updated to reflect the committed changes.

Why isn't this just CFLAGS+=-fPIC ?

Because e.g. powerpc64 doesn't need it.

What that says to me is that we need a standard ${CFLAGS_PIC} variable or some such, which is defined to -fPIC on most platforms and empty on powerpc64, rather than pollute every port makefile with an ever-changing list of which arches need -fPIC and which don't.