Page MenuHomeFreeBSD

converters/lua-iconv: fix build on armv7
ClosedPublic

Authored by pkubaj on Aug 24 2019, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 2:33 PM
Unknown Object (File)
Feb 10 2024, 8:26 PM
Unknown Object (File)
Feb 10 2024, 8:26 PM
Unknown Object (File)
Feb 10 2024, 8:21 PM
Unknown Object (File)
Feb 10 2024, 1:10 AM
Unknown Object (File)
Jan 13 2024, 9:04 AM
Unknown Object (File)
Dec 20 2023, 3:46 AM
Unknown Object (File)
Dec 3 2023, 9:40 AM

Details

Summary

armv7 requires -fPIC too.

PR: 239623

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Approved. IMHO there should also be an entry for armv6.

This revision is now accepted and ready to land.Aug 31 2019, 11:13 AM

Why isn't this just CFLAGS+=-fPIC ?

Because e.g. powerpc64 doesn't need it.

This revision was automatically updated to reflect the committed changes.

Why isn't this just CFLAGS+=-fPIC ?

Because e.g. powerpc64 doesn't need it.

What that says to me is that we need a standard ${CFLAGS_PIC} variable or some such, which is defined to -fPIC on most platforms and empty on powerpc64, rather than pollute every port makefile with an ever-changing list of which arches need -fPIC and which don't.