Page MenuHomeFreeBSD
Differential D21437

Fix compilation of locore.S with clang
ClosedPublic
Actions

Authored by mhorne on Aug 27 2019, 2:04 PM.
Tags
None
Referenced Files
F83585491: D21437.id61352.diff
Sun, May 12, 6:51 AM
Unknown Object (File)
Fri, May 10, 3:02 PM
Unknown Object (File)
Thu, May 9, 4:25 AM
Unknown Object (File)
Tue, May 7, 6:58 PM
Unknown Object (File)
Fri, May 3, 11:58 PM
Unknown Object (File)
Sun, Apr 28, 12:53 PM
Unknown Object (File)
Fri, Apr 19, 4:57 PM
Unknown Object (File)
Nov 15 2023, 8:16 AM
View All 35 Files
Subscribers
imp

Details

Reviewers
br
markj
Commits
rS352036: Fix compilation of locore.S with clang
Summary

The branch from _start to mpentry has to cross a large section of data;
an offset larger than can be specified with a 12-bit branch immediate.
Fix this by converting the branch to an unconditional jump. The gcc
assembler does this conversion silently but is not done automatically by
clang.

Reported by: Jeremy Bennett <jeremy.bennett@embecosm.com>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26136
Build 24653: arc lint + arc unit

Event Timeline

mhorne created this revision.Aug 27 2019, 2:04 PM
Harbormaster completed remote builds in B26136: Diff 61352.Aug 27 2019, 2:04 PM
markj added inline comments.Aug 27 2019, 2:22 PM
sys/riscv/riscv/locore.S
73

I would suggest adding a comment, since otherwise it looks like something that should be simplified.

markj accepted this revision.Aug 27 2019, 2:22 PM
This revision is now accepted and ready to land.Aug 27 2019, 2:22 PM
mhorne updated this revision to Diff 61809.Sep 8 2019, 7:37 PM

Add comment explaining the change

This revision now requires review to proceed.Sep 8 2019, 7:37 PM
Harbormaster completed remote builds in B26340: Diff 61809.Sep 8 2019, 7:37 PM
markj accepted this revision.Sep 8 2019, 7:48 PM

Approved.

This revision is now accepted and ready to land.Sep 8 2019, 7:48 PM
Closed by commit rS352036: Fix compilation of locore.S with clang (authored by mhorne). · Explain WhySep 8 2019, 7:53 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rS352036: Fix compilation of locore.S with clang.
Herald added a subscriber: imp. · View Herald TranscriptSep 8 2019, 7:53 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
5 lines

Diff 61352

View Options

sys/riscv/riscv/locore.S

Loading...