Page MenuHomeFreeBSD
Differential D21402

converters/lua-iconv: fix build on armv7
ClosedPublic
Actions

Authored by pkubaj on Aug 24 2019, 12:56 PM.
Tags
None
Referenced Files
F131462413: D21402.diff
Wed, Oct 8, 7:33 AM
F131423534: D21402.id61218.diff
Tue, Oct 7, 9:55 PM
Unknown Object (File)
Fri, Sep 19, 4:51 PM
Unknown Object (File)
Sat, Sep 13, 10:09 AM
Unknown Object (File)
Fri, Sep 12, 12:15 AM
Unknown Object (File)
Thu, Sep 11, 7:26 AM
Unknown Object (File)
Wed, Sep 10, 3:25 PM
Unknown Object (File)
Wed, Sep 10, 12:26 PM
View All Files
Subscribers
andrew_tao173.riddles.org.uk

Details

Reviewers
linimon
mat
tcberner
Commits
rP510712: converters/lua-iconv: fix build on armv7 and armv6
Summary

armv7 requires -fPIC too.

PR: 239623

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 26070
Build 24610: arc lint + arc unit

Event Timeline

pkubaj created this revision.Aug 24 2019, 12:56 PM
Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptAug 24 2019, 12:56 PM
Harbormaster completed remote builds in B26070: Diff 61218.Aug 24 2019, 12:56 PM
linimon accepted this revision.Aug 31 2019, 11:13 AM

Approved. IMHO there should also be an entry for armv6.

This revision is now accepted and ready to land.Aug 31 2019, 11:13 AM
andrew_tao173.riddles.org.uk added a comment.Aug 31 2019, 11:28 AM

Why isn't this just CFLAGS+=-fPIC ?

pkubaj added a comment.Sep 1 2019, 5:43 PM
In D21402#467690, @andrew_tao173.riddles.org.uk wrote:

Why isn't this just CFLAGS+=-fPIC ?

Because e.g. powerpc64 doesn't need it.

Closed by commit rP510712: converters/lua-iconv: fix build on armv7 and armv6 (authored by pkubaj). · Explain WhySep 1 2019, 5:46 PM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP510712: converters/lua-iconv: fix build on armv7 and armv6.
andrew_tao173.riddles.org.uk added a comment.Sep 1 2019, 6:17 PM
In D21402#467883, @pkubaj wrote:
In D21402#467690, @andrew_tao173.riddles.org.uk wrote:

Why isn't this just CFLAGS+=-fPIC ?

Because e.g. powerpc64 doesn't need it.

What that says to me is that we need a standard ${CFLAGS_PIC} variable or some such, which is defined to -fPIC on most platforms and empty on powerpc64, rather than pollute every port makefile with an ever-changing list of which arches need -fPIC and which don't.

Revision Contents
Changeset List

PathSize
converters/
lua-iconv/
1 line

Diff 61218

View Options

converters/lua-iconv/Makefile

Loading...