Page MenuHomeFreeBSD
Differential D21363

Properly update FSInfo block after generation.
ClosedPublic
Actions

Authored by delphij on Aug 22 2019, 6:04 AM.
Tags
None
Referenced Files
F140128760: D21363.id61107.diff
Sat, Dec 20, 3:16 PM
Unknown Object (File)
Fri, Dec 19, 11:29 PM
Unknown Object (File)
Wed, Dec 17, 8:31 AM
Unknown Object (File)
Wed, Dec 17, 7:43 AM
Unknown Object (File)
Nov 20 2025, 7:35 PM
Unknown Object (File)
Nov 20 2025, 7:33 PM
Unknown Object (File)
Nov 20 2025, 7:32 PM
Unknown Object (File)
Nov 20 2025, 7:20 PM
View All 78 Files
Subscribers
imp

Details

Reviewers
emaste
cem
Commits
rS351415: Properly update FSInfo block after generation.
Summary

After populating the filesystem, write a FSInfo block with
proper information.

Test Plan

Generate a FAT32 image and run fsck_msdosfs on it.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26005
Build 24553: arc lint + arc unit

Event Timeline

delphij created this revision.Aug 22 2019, 6:04 AM
Harbormaster completed remote builds in B26005: Diff 61107.Aug 22 2019, 6:05 AM
emaste accepted this revision.Aug 22 2019, 12:57 PM

Would you add msdosfs_fsiflush after msdosfs_mount, matching the order in sys/fs/msdosfs/msdosfs_vfsops.c? It'll be a small help in future efforts to deduplicate these.

This revision is now accepted and ready to land.Aug 22 2019, 12:57 PM
cem accepted this revision.Aug 22 2019, 3:13 PM
Closed by commit rS351415: Properly update FSInfo block after generation. (authored by delphij). · Explain WhyAug 23 2019, 5:24 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rS351415: Properly update FSInfo block after generation..
Herald added a subscriber: imp. · View Herald TranscriptAug 23 2019, 5:24 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
1 line
2 lines
msdos/
28 lines

Diff 61107

View Options

usr.sbin/makefs/msdos.h

Loading...
View Options

usr.sbin/makefs/msdos.c

Loading...
View Options

usr.sbin/makefs/msdos/msdosfs_vfsops.c

Loading...