pf: Save the protocol number in the pf_fragment
ClosedPublic
Actions

Authored by kp on Jun 10 2015, 11:26 PM.

Details

Reviewers

philip
gnn

Commits

rS284260: pf: Save the protocol number in the pf_fragment

Summary

When we try to look up a pf_fragment with pf_find_fragment() we compare (see
pf_frag_compare()) addresses (and family), id but also protocol.
We failed to save the protocol to the pf_fragment in pf_fragcache(), resulting
in failing reassembly.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kp updated this revision to Diff 6090.Jun 10 2015, 11:26 PM

kp retitled this revision from to pf: Save the protocol number in the pf_fragment.

kp updated this object.

kp edited the test plan for this revision. (Show Details)

kp added reviewers: gnn, philip.

kp set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJun 10 2015, 11:26 PM

Are you sure that's all of the fields in (*frag) now? :-)

Approved by: philip (mentor)

This revision is now accepted and ready to land.Jun 11 2015, 3:26 AM

Yes. We need to get all of the fields used in pf_frag_compare(). That's fr_id, fr_proto, fr_af, fr_src and fr_dst.

Closed by commit rS284260: pf: Save the protocol number in the pf_fragment (authored by kp). · Explain WhyJun 11 2015, 1:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_norm.c

1 line

Diff 6090

View Options

pf: Save the protocol number in the pf_fragmentClosedPublicActions