Page MenuHomeFreeBSD
Differential D20900

Increase YPMAXRECORD to 16M to be compatible with Linux.
ClosedPublic
Actions

Authored by kib on Jul 9 2019, 11:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 12:30 PM
Unknown Object (File)
Thu, Oct 24, 8:11 AM
Unknown Object (File)
Oct 16 2024, 10:38 PM
Unknown Object (File)
Oct 8 2024, 6:49 PM
Unknown Object (File)
Oct 3 2024, 9:15 AM
Unknown Object (File)
Oct 2 2024, 11:54 PM
Unknown Object (File)
Sep 28 2024, 8:43 AM
Unknown Object (File)
Sep 28 2024, 8:26 AM
View All Files
Subscribers
• ian
imp
markj
slavash

Details

Reviewers
markj
Commits
rS350957: Increase YPMAXRECORD to 16M to be compatible with Linux.
Summary

Glibc made same change, increasing the allowed length for keys and values in YP to 16M, in 2013. We need this for compatibility with very large automounter maps.

Since YP protocol definition uses the constant to declare variable-size opaque byte strings, the change should be binary compatible with existing installations which do not expose keys or values larger than 1024 bytes.

All uses of local variables with YPMAXRECORD sizes were removed to avoid insane stack use. On the other hand, variables with static lifetime should be fine and only result in increased VA use.

Sponsored by: Mellanox Technologies

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 25724

Event Timeline

kib created this revision.Jul 9 2019, 11:05 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 9 2019, 11:05 PM
Harbormaster completed remote builds in B25274: Diff 59582.Jul 9 2019, 11:05 PM
kib edited the summary of this revision. (Show Details)Jul 9 2019, 11:13 PM
kib updated this revision to Diff 59596.Jul 10 2019, 10:52 AM

Accumulated bugfixes.

Harbormaster completed remote builds in B25280: Diff 59596.Jul 10 2019, 10:52 AM
• ian added a subscriber: • ian.Aug 6 2019, 11:11 PM
• ian added inline comments.
lib/libc/net/gethostbynis.c
91–92

s/&ypbuf/ypbuf/

same change a few lines down in result= line

lib/libc/net/getnetbynis.c
80–81

&ypbuf here and 3 lines down as well

In fact, it looks like this pattern of the old code using '&array' instead of just 'array' is repeated in more of the changes below, I'm not going to flag every one of them right now (because I was just doing a "quick glance" and have to get back to $work).

kib updated this revision to Diff 60538.Aug 7 2019, 10:56 AM
kib marked 2 inline comments as done.

Fix bugs pointed out by ian. I did not found other instances of it.

Harbormaster completed remote builds in B25724: Diff 60538.Aug 7 2019, 10:56 AM
markj added a subscriber: markj.Aug 7 2019, 9:02 PM
markj added inline comments.
usr.sbin/rpc.yppasswdd/yppasswdd_server.c
368

Should this be a goto as well?

kib updated this revision to Diff 60558.Aug 7 2019, 9:25 PM
kib marked an inline comment as done.

Do not leak pwbuf.

Harbormaster completed remote builds in B25735: Diff 60558.Aug 7 2019, 9:25 PM
markj accepted this revision.Aug 8 2019, 1:12 AM

There are no checks for memory allocation failures, but otherwise it looks ok to me.

This revision is now accepted and ready to land.Aug 8 2019, 1:12 AM
kib updated this revision to Diff 60581.Aug 8 2019, 3:15 PM

Add checks for ENOMEM.

This revision now requires review to proceed.Aug 8 2019, 3:15 PM
Harbormaster completed remote builds in B25747: Diff 60581.Aug 8 2019, 3:15 PM
markj accepted this revision.Aug 8 2019, 9:35 PM
markj added inline comments.
usr.sbin/yppush/yppush_main.c
448

return YP_YPERR?

This revision is now accepted and ready to land.Aug 8 2019, 9:35 PM
kib added inline comments.Aug 9 2019, 7:09 AM
usr.sbin/yppush/yppush_main.c
448

I am not sure.

I returned 0 on principle that malloc might fail mostly due to insane size, not because app should handle real OOM situation. And then, returning 0 means that the iteration over the entries should continue, which is what I believe is the right action.

markj added inline comments.Aug 9 2019, 3:42 PM
usr.sbin/yppush/yppush_main.c
448

Ok. It might be worth a comment.

kib updated this revision to Diff 60622.Aug 9 2019, 8:30 PM
kib marked 2 inline comments as done.

Add comment hinting why we do not stop iteration on asprintf (malloc) failure.

This revision now requires review to proceed.Aug 9 2019, 8:30 PM
Harbormaster completed remote builds in B25765: Diff 60622.Aug 9 2019, 8:30 PM
markj accepted this revision.Aug 9 2019, 8:41 PM
This revision is now accepted and ready to land.Aug 9 2019, 8:41 PM
Closed by commit rS350957: Increase YPMAXRECORD to 16M to be compatible with Linux. (authored by kib). · Explain WhyAug 12 2019, 8:27 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS350957: Increase YPMAXRECORD to 16M to be compatible with Linux..

Revision Contents
Changeset List

PathSize
include/
rpcsvc/
2 lines
2 lines
2 lines
lib/
libc/
net/
7 lines
7 lines
11 lines
rpc/
10 lines
usr.sbin/
rpc.yppasswdd/
29 lines
rpc.ypupdated/
2 lines
ypldap/
48 lines
yppush/
13 lines
ypserv/
3 lines

Diff 60538

View Options

include/rpcsvc/yp.x

Loading...
View Options

include/rpcsvc/yp_prot.h

Loading...
View Options

include/rpcsvc/ypxfrd.x

Loading...
View Options

lib/libc/net/gethostbynis.c

Loading...
View Options

lib/libc/net/getnetbynis.c

Loading...
View Options

lib/libc/net/getservent.c

Loading...
View Options

lib/libc/rpc/getrpcent.c

Loading...
View Options

usr.sbin/rpc.yppasswdd/yppasswdd_server.c

Loading...
View Options

usr.sbin/rpc.ypupdated/yp_dbupdate.c

Loading...
View Options

usr.sbin/ypldap/yp.c

Loading...
View Options

usr.sbin/yppush/yppush_main.c

Loading...
View Options

usr.sbin/ypserv/yp_server.c

Loading...