Avoid calling blessed() more often than needed.
ClosedPublic
Actions

Authored by markj on Aug 2 2019, 3:25 PM.

Tags

None

Referenced Files

	F154105964: D21135.id60391.diff
	Sun, Apr 26, 5:54 AM

	Unknown Object (File)
	Sat, Apr 25, 5:50 AM

	Unknown Object (File)
	Fri, Apr 24, 7:52 AM

	Unknown Object (File)
	Thu, Apr 23, 5:25 AM

	Unknown Object (File)
	Wed, Apr 22, 7:27 PM

	Unknown Object (File)
	Wed, Apr 22, 11:29 AM

	Unknown Object (File)
	Tue, Apr 21, 7:17 AM

	Unknown Object (File)
	Tue, Apr 21, 2:25 AM

View All Files

Subscribers

imp

Details

Reviewers

jhb

Commits

rS350540: Only check the blessings table for known LORs.

Summary

Only call it once we've detected a reversal and have set a flag in the
corresponding matrix entries. The badstacks handler now must also omit
stacks corresponding to blessed lock pairs.

Test Plan

Checked that we don't log blessed LORs in badstacks.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25643
Build 24236: arc lint + arc unit

Event Timeline

markj created this revision.Aug 2 2019, 3:25 PM

Harbormaster completed remote builds in B25643: Diff 60391.Aug 2 2019, 3:25 PM

markj edited the test plan for this revision. (Show Details)Aug 2 2019, 3:25 PM

markj added a reviewer: jhb.

jhb accepted this revision.Aug 2 2019, 3:46 PM

This revision is now accepted and ready to land.Aug 2 2019, 3:46 PM

Closed by commit rS350540: Only check the blessings table for known LORs. (authored by markj). · Explain WhyAug 2 2019, 6:01 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS350540: Only check the blessings table for known LORs..

Herald added a subscriber: imp. · View Herald TranscriptAug 2 2019, 6:01 PM

lwhsu mentioned this in D21134: Avoid calling blessed() more often than needed..Aug 3 2019, 9:47 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_witness.c

19 lines

Diff 60391

View Options

Avoid calling blessed() more often than needed.ClosedPublicActions