Remove unused variable and set macro __unused to another.
ClosedPublic
Actions

Authored by araujo on May 31 2015, 5:32 AM.

Details

Reviewers

• rodrigc
• hselasky

Commits

rS284744: Remove unused variables to silence CLANG warnings.

Summary

Remove unused variable and silence the CLANG warning for variable dummy. Also remove some weird new blank lines.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

araujo updated this revision to Diff 5822.May 31 2015, 5:32 AM

araujo retitled this revision from to Remove unused variable and set macro __unused to another..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

araujo added reviewers: • rodrigc, • hselasky.

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2015, 5:32 AM

I wouldn't bother with __unused, and just take the dummy variable
out entirely.
I would confirm with @hselasky just to make sure.

Looks good.

I think we should simply "(void)" cast the unused function return values, and remove the __unused altogether.

--HPS

Remove the __unused dummy variable and cast the function with void.

Looks good.

This revision is now accepted and ready to land.Jun 17 2015, 6:54 AM

Closed by commit rS284744: Remove unused variables to silence CLANG warnings. (authored by araujo). · Explain WhyJun 24 2015, 1:34 AM

This revision was automatically updated to reflect the committed changes.

araujo mentioned this in rS284744: Remove unused variables to silence CLANG warnings..

Revision Contents
Changeset List

Path

Size

lib/

libusb/

libusb10.c

11 lines

libusb20_desc.c

7 lines

Diff 5989

View Options

lib/libusb/libusb10.c