Page MenuHomeFreeBSD
Differential D20897

Use 'retval' label for first error in syscallenter().
ClosedPublic
Actions

Authored by jhb on Jul 9 2019, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 7, 7:28 AM
Unknown Object (File)
Sun, May 3, 5:51 PM
Unknown Object (File)
Sun, May 3, 7:10 AM
Unknown Object (File)
Wed, Apr 29, 3:18 PM
Unknown Object (File)
Fri, Apr 24, 1:01 PM
Unknown Object (File)
Apr 20 2026, 4:40 PM
Unknown Object (File)
Apr 20 2026, 6:55 AM
Unknown Object (File)
Apr 19 2026, 9:21 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS349871: Use 'retval' label for first error in syscallenter().
Summary

This is more consistent with the rest of the function and lets us
unindent most of the function.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 25271
Build 23938: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 9 2019, 11:02 PM
Harbormaster completed remote builds in B25271: Diff 59583.Jul 9 2019, 11:02 PM
jhb added a child revision: D20898: Always set td_errno to the error value of a system call..Jul 9 2019, 11:03 PM
kib accepted this revision.Jul 9 2019, 11:15 PM
kib added inline comments.
sys/kern/subr_syscall.c
92

I would use the opportunity and style the flags checks, (p_flag & P_TRACED) != 0 etc.

This revision is now accepted and ready to land.Jul 9 2019, 11:15 PM
jhb marked an inline comment as done.Jul 9 2019, 11:50 PM
Closed by commit rS349871: Use 'retval' label for first error in syscallenter(). (authored by jhb). · Explain WhyJul 9 2019, 11:58 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS349871: Use 'retval' label for first error in syscallenter()..
Herald added a subscriber: imp. · View Herald TranscriptJul 9 2019, 11:58 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
97 lines

Diff 59583

View Options

sys/kern/subr_syscall.c

Loading...