Differential D20897

Use 'retval' label for first error in syscallenter().
ClosedPublic
Actions

Authored by jhb on Jul 9 2019, 11:02 PM.

Details

Reviewers

kib

Commits

rS349871: Use 'retval' label for first error in syscallenter().

Summary

This is more consistent with the rest of the function and lets us
unindent most of the function.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 9 2019, 11:02 PM

Harbormaster completed remote builds in B25271: Diff 59583.Jul 9 2019, 11:02 PM

jhb added a child revision: D20898: Always set td_errno to the error value of a system call..Jul 9 2019, 11:03 PM

kib accepted this revision.Jul 9 2019, 11:15 PM

kib added inline comments.

sys/kern/subr_syscall.c
92 ↗	(On Diff #59583)	I would use the opportunity and style the flags checks, (p_flag & P_TRACED) != 0 etc.

This revision is now accepted and ready to land.Jul 9 2019, 11:15 PM

jhb marked an inline comment as done.Jul 9 2019, 11:50 PM

Closed by commit rS349871: Use 'retval' label for first error in syscallenter(). (authored by jhb). · Explain WhyJul 9 2019, 11:58 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS349871: Use 'retval' label for first error in syscallenter()..

Herald added a subscriber: imp. · View Herald TranscriptJul 9 2019, 11:58 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

subr_syscall.c

95 lines

Diff 59589

View Options

head/sys/kern/subr_syscall.c

Use 'retval' label for first error in syscallenter().ClosedPublicActions