Page MenuHomeFreeBSD
Differential D20855

replace 'goto' with 'else' in vm_map_wire_locked.
ClosedPublic
Actions

Authored by dougm on Jul 4 2019, 4:28 PM.
Tags
None
Referenced Files
F167179378: D20855.id59409.diff
Wed, Aug 19, 4:52 PM
F167072484: D20855.id59397.diff
Tue, Aug 18, 8:41 PM
F167058733: D20855.id59409.diff
Tue, Aug 18, 8:16 PM
Unknown Object (File)
Mon, Aug 17, 1:59 PM
Unknown Object (File)
Mon, Aug 17, 12:30 PM
Unknown Object (File)
Sun, Aug 16, 8:25 PM
Unknown Object (File)
Sat, Aug 15, 9:20 PM
Unknown Object (File)
Fri, Aug 14, 8:20 PM
View All Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked.
Summary

Eliminate a goto and a label. There is no change to the resulting amd64 machine code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm created this revision.Jul 4 2019, 4:28 PM
dougm added a reviewer: markj.Jul 4 2019, 7:08 PM
markj accepted this revision.Jul 4 2019, 7:10 PM
This revision is now accepted and ready to land.Jul 4 2019, 7:10 PM
alc added inline comments.Jul 4 2019, 7:10 PM
vm_map.c
3287 ↗(On Diff #59397)

The comment suffices given the braces. You don't need the semicolon.

dougm updated this revision to Diff 59408.Jul 4 2019, 7:15 PM

No semicolon.

This revision now requires review to proceed.Jul 4 2019, 7:15 PM
markj accepted this revision.Jul 4 2019, 7:16 PM
This revision is now accepted and ready to land.Jul 4 2019, 7:16 PM
Closed by commit rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked. (authored by dougm). · Explain WhyJul 4 2019, 7:18 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked..
Herald added a subscriber: imp. · View Herald TranscriptJul 4 2019, 7:18 PM

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
8 lines

Diff 59409

View Options

head/sys/vm/vm_map.c

Loading...