Differential D20855

replace 'goto' with 'else' in vm_map_wire_locked.
ClosedPublic
Actions

Authored by dougm on Jul 4 2019, 4:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 12, 6:16 PM

	Unknown Object (File)
	Thu, Mar 12, 12:11 PM

	Unknown Object (File)
	Thu, Mar 12, 12:47 AM

	Unknown Object (File)
	Sun, Mar 8, 6:44 PM

	Unknown Object (File)
	Sun, Mar 8, 6:44 PM

	Unknown Object (File)
	Sun, Mar 8, 7:53 AM

	Unknown Object (File)
	Wed, Mar 4, 1:30 PM

	Unknown Object (File)
	Wed, Mar 4, 1:30 PM

View All 98 Files

Subscribers

imp

Details

Reviewers

alc
markj

Commits

rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked.

Summary

Eliminate a goto and a label. There is no change to the resulting amd64 machine code.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm created this revision.Jul 4 2019, 4:28 PM

dougm added a reviewer: markj.Jul 4 2019, 7:08 PM

markj accepted this revision.Jul 4 2019, 7:10 PM

This revision is now accepted and ready to land.Jul 4 2019, 7:10 PM

alc added inline comments.Jul 4 2019, 7:10 PM

vm_map.c
3284	The comment suffices given the braces. You don't need the semicolon.

No semicolon.

This revision now requires review to proceed.Jul 4 2019, 7:15 PM

markj accepted this revision.Jul 4 2019, 7:16 PM

This revision is now accepted and ready to land.Jul 4 2019, 7:16 PM

Closed by commit rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked. (authored by dougm). · Explain WhyJul 4 2019, 7:18 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked..

Herald added a subscriber: imp. · View Herald TranscriptJul 4 2019, 7:18 PM

Revision Contents
Changeset List

Path

Size

vm_map.c

8 lines

Diff 59408

View Options

replace 'goto' with 'else' in vm_map_wire_locked.ClosedPublicActions