Page MenuHomeFreeBSD
Differential D20855

replace 'goto' with 'else' in vm_map_wire_locked.
ClosedPublic
Actions

Authored by dougm on Jul 4 2019, 4:28 PM.
Tags
None
Referenced Files
F136952246: D20855.id.diff
Thu, Nov 20, 7:50 PM
F136950946: D20855.id59408.diff
Thu, Nov 20, 7:43 PM
F136950853: D20855.id59409.diff
Thu, Nov 20, 7:43 PM
F136950701: D20855.id59397.diff
Thu, Nov 20, 7:42 PM
F136948838: D20855.diff
Thu, Nov 20, 7:32 PM
Unknown Object (File)
Mon, Nov 10, 11:19 PM
Unknown Object (File)
Sun, Nov 2, 1:00 PM
Unknown Object (File)
Oct 21 2025, 5:30 PM
View All 78 Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked.
Summary

Eliminate a goto and a label. There is no change to the resulting amd64 machine code.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Jul 4 2019, 4:28 PM
dougm added a reviewer: markj.Jul 4 2019, 7:08 PM
markj accepted this revision.Jul 4 2019, 7:10 PM
This revision is now accepted and ready to land.Jul 4 2019, 7:10 PM
alc added inline comments.Jul 4 2019, 7:10 PM
vm_map.c
3284

The comment suffices given the braces. You don't need the semicolon.

dougm updated this revision to Diff 59408.Jul 4 2019, 7:15 PM

No semicolon.

This revision now requires review to proceed.Jul 4 2019, 7:15 PM
markj accepted this revision.Jul 4 2019, 7:16 PM
This revision is now accepted and ready to land.Jul 4 2019, 7:16 PM
Closed by commit rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked. (authored by dougm). · Explain WhyJul 4 2019, 7:18 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS349744: Replace a 'goto' with an 'else' in vm_map_wire_locked..
Herald added a subscriber: imp. · View Herald TranscriptJul 4 2019, 7:18 PM

Revision Contents
Changeset List

PathSize
8 lines

Diff 59408

View Options

vm_map.c

Loading...