Page MenuHomeFreeBSD
Differential D20701

rc.d/motd: Update motd more robustly
ClosedPublic
Actions

Authored by cem on Jun 19 2019, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 25, 10:02 PM
Unknown Object (File)
Wed, May 20, 2:58 PM
Unknown Object (File)
Wed, May 20, 2:13 PM
Unknown Object (File)
Wed, May 20, 9:34 AM
Unknown Object (File)
Wed, May 20, 6:14 AM
Unknown Object (File)
Tue, May 19, 3:24 AM
Unknown Object (File)
Sat, May 16, 9:29 AM
Unknown Object (File)
Tue, May 12, 11:12 PM
View All Files
Subscribers
imp

Details

Reviewers
vangyzen
allanjude
Commits
rS349256: rc.d/motd: Update motd more robustly
Summary

Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24940
Build 23665: arc lint + arc unit

Event Timeline

cem created this revision.Jun 19 2019, 8:06 PM
Harbormaster completed remote builds in B24940: Diff 58803.Jun 19 2019, 8:06 PM
vangyzen accepted this revision.Jun 19 2019, 8:09 PM
This revision is now accepted and ready to land.Jun 19 2019, 8:09 PM
cem updated this revision to Diff 58805.Jun 19 2019, 8:21 PM

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

This revision now requires review to proceed.Jun 19 2019, 8:21 PM
Harbormaster completed remote builds in B24941: Diff 58805.Jun 19 2019, 8:21 PM
allanjude accepted this revision.Jun 19 2019, 9:07 PM
This revision is now accepted and ready to land.Jun 19 2019, 9:07 PM
vangyzen accepted this revision.Jun 21 2019, 2:21 AM
Closed by commit rS349256: rc.d/motd: Update motd more robustly (authored by cem). · Explain WhyJun 21 2019, 2:38 AM
This revision was automatically updated to reflect the committed changes.
cem added a commit: rS349256: rc.d/motd: Update motd more robustly.
Herald added a subscriber: imp. · View Herald TranscriptJun 21 2019, 2:38 AM

Revision Contents
Changeset List

PathSize
libexec/
rc/
rc.d/
11 lines

Diff 58803

View Options

libexec/rc/rc.d/motd

Loading...