Page MenuHomeFreeBSD

rc.d/motd: Update motd more robustly
ClosedPublic

Authored by cem on Jun 19 2019, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 14, 9:38 PM
Unknown Object (File)
Sat, Jul 4, 7:43 AM
Unknown Object (File)
Thu, Jul 2, 11:06 PM
Unknown Object (File)
Sun, Jun 28, 11:50 AM
Unknown Object (File)
Tue, Jun 23, 10:47 PM
Unknown Object (File)
Tue, Jun 23, 2:48 AM
Unknown Object (File)
Jun 5 2026, 9:58 PM
Unknown Object (File)
May 30 2026, 7:31 AM
Subscribers

Details

Summary

Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24940
Build 23665: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 19 2019, 8:09 PM

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

This revision now requires review to proceed.Jun 19 2019, 8:21 PM
This revision is now accepted and ready to land.Jun 19 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.