Page MenuHomeFreeBSD

rc.d/motd: Update motd more robustly
ClosedPublic

Authored by cem on Jun 19 2019, 8:06 PM.
Tags
None
Referenced Files
F137205984: D20701.id58803.diff
Fri, Nov 21, 12:31 PM
Unknown Object (File)
Thu, Nov 20, 7:47 PM
Unknown Object (File)
Thu, Nov 20, 7:35 PM
Unknown Object (File)
Thu, Nov 20, 7:34 PM
Unknown Object (File)
Thu, Nov 20, 7:34 PM
Unknown Object (File)
Thu, Nov 20, 7:21 PM
Unknown Object (File)
Thu, Nov 20, 12:18 AM
Unknown Object (File)
Tue, Nov 18, 6:39 AM
Subscribers

Details

Summary

Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24940
Build 23665: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 19 2019, 8:09 PM

As mjg@ points out, the mktemp file may be on a different filesystem than /etc
(e.g., tmpfs, but any other filesystem invalidates the initial fsync). Copy to
a temporary /etc file, sync that, then rename over /etc/motd.

This revision now requires review to proceed.Jun 19 2019, 8:21 PM
This revision is now accepted and ready to land.Jun 19 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.