Add WebRTC support to www/qt5-webengine. The patches were again taken from www/chromium.
Related PR: 236915
Paths
| Differential D19900 Authored by kai on Apr 13 2019, 3:43 PM.
Details Summary Add WebRTC support to www/qt5-webengine. The patches were again taken from www/chromium. Related PR: 236915 Test Plan
Diff Detail
Event TimelineHarbormaster completed remote builds in B23659: Diff 56171.Apr 13 2019, 3:44 PM2019-04-13 15:44:00 (UTC+0) Comment Actions Removed the comment in the Makefile regarding WebRTC and updated the date in UPDATING. Harbormaster completed remote builds in B23753: Diff 56366.Apr 18 2019, 9:40 PM2019-04-18 21:40:31 (UTC+0) Comment Actions I tested the patch and it builds fine for me (12.0-STABLE r347145 amd64). I could not complete the runtime test https://test.webrtc.org/ because I disabled INET6 on my system, so that the tests do not go through that step. Microphone works fine, camera does not but I never used it with any software so I can not say that it is WebRTC's fault. UDP and TCP work. I thought getting WebRTC to work would have solved bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237277 about videos being reproduced with wrong colors (see comment 5, more precisely the link https://wiki.qt.io/QtWebEngine/VideoAcceleration ), however it is not fixed for me on falkon. Maybe this could be investigated a bit. This revision now requires changes to proceed.May 7 2019, 9:59 AM2019-05-07 09:59:38 (UTC+0) Comment Actions I change my status revision to approved: it is unsure if the bug I referenced depends on webrtc and, if it does, it can be dealt with another time. This revision is now accepted and ready to land.Jun 2 2019, 8:45 PM2019-06-02 20:45:58 (UTC+0) Comment Actions
I assumed it's in your garden :) Closed by commit rP504068: www/qt5-webengine: Enable support for WebRTC and video capture devices (authored by kai). · Explain WhyJun 13 2019, 8:45 AM2019-06-13 08:45:07 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 58584 head/UPDATING
head/www/qt5-webengine/Makefile
head/www/qt5-webengine/files/patch-clang
head/www/qt5-webengine/files/patch-src_3rdparty_chromium_media_capture_video_create__video__capture__device__factory.cc
head/www/qt5-webengine/files/patch-src_3rdparty_chromium_media_capture_video_shared__memory__handle__provider.h
head/www/qt5-webengine/files/patch-src_3rdparty_chromium_media_capture_video_shared__memory__handle__provider.ccLoading... |