Differential D20427

ips(4): add missing braces
ClosedPublic
Actions

Authored by lwhsu on May 27 2019, 2:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 23, 9:52 PM

	Unknown Object (File)
	Mon, Mar 23, 2:46 AM

	Unknown Object (File)
	Thu, Mar 19, 6:14 AM

	Unknown Object (File)
	Mon, Mar 9, 5:25 PM

	Unknown Object (File)
	Mon, Mar 9, 2:30 AM

	Unknown Object (File)
	Sun, Mar 1, 3:15 PM

	Unknown Object (File)
	Feb 3 2026, 1:51 AM

	Unknown Object (File)
	Jan 17 2026, 9:01 PM

View All 93 Files

Subscribers

imp

Details

Reviewers

scottl

Commits

rS360297: MFC r348366 (by lwhsu):
rS348366: Add the likely missing braces in ips(4). This is found by gcc warning that

Summary

Add the very likely missing braces in ips(4). This is found by gcc warning that
the code is not guarded by the if clause and has misleading indentation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24536
Build 23327: arc lint + arc unit

Event Timeline

lwhsu created this revision.May 27 2019, 2:50 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 27 2019, 2:50 PM

Harbormaster completed remote builds in B24536: Diff 57954.May 27 2019, 2:50 PM

lwhsu added a reviewer: scottl.May 27 2019, 2:51 PM

lwhsu removed a subscriber: scottl.

scottl accepted this revision.May 27 2019, 11:04 PM

This revision is now accepted and ready to land.May 27 2019, 11:04 PM

Closed by commit rS348366: Add the likely missing braces in ips(4). This is found by gcc warning that (authored by lwhsu). · Explain WhyMay 29 2019, 6:11 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rS360297: MFC r348366 (by lwhsu):.Apr 25 2020, 12:39 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ips/

ips.c

3 lines

Diff 57954

View Options

ips(4): add missing bracesClosedPublicActions