Page MenuHomeFreeBSD
Differential D20356

Pass resize parameter to vm_map_entry_resize_free
ClosedPublic
Actions

Authored by dougm on May 22 2019, 4:33 PM.
Tags
None
Referenced Files
F151151990: D20356.id.diff
Mon, Apr 6, 11:03 AM
F151146538: D20356.id.diff
Mon, Apr 6, 10:04 AM
Unknown Object (File)
Sat, Apr 4, 9:44 AM
Unknown Object (File)
Sat, Apr 4, 9:12 AM
Unknown Object (File)
Sat, Apr 4, 5:33 AM
Unknown Object (File)
Fri, Apr 3, 6:00 PM
Unknown Object (File)
Fri, Apr 3, 6:39 AM
Unknown Object (File)
Thu, Apr 2, 9:48 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rS348115: Passing a parameter to vm_map_entry_resize_free that describes the
Summary

This is a small piece broken off of the change under review at D19826. Passing a parameter to vm_map_entry_resize_free that describes the amount of resizing reduces the number of functions changing the vm_map invariants regarding the max_free field of map entries.

Test Plan

I've tested with a test program that pounds the vm_map and seen no obvious performance impact from this change.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.May 22 2019, 4:33 PM
dougm updated this revision to Diff 57701.May 22 2019, 4:38 PM

-U99999

kib added a comment.May 22 2019, 4:57 PM

Other than the note about if()s, this looks fine.

vm_map.c
4325

I find this nesting of if()s cleaner than repeated condition in your variant. It is clear that we do some cleanup, and the kind of cleanup depends on gap_deleted.

dougm updated this revision to Diff 57703.May 22 2019, 5:03 PM

Restore indentation. Wrap long line.

markj added inline comments.May 22 2019, 5:06 PM
vm_map.c
4353

Did you delete the wrong line?

dougm updated this revision to Diff 57704.May 22 2019, 5:09 PM

Fix the conflict with the old patch correctly, this time.

dougm marked an inline comment as done.May 22 2019, 5:10 PM
dougm added inline comments.
vm_map.c
4353

Yep.

kib accepted this revision.May 22 2019, 5:35 PM
kib added inline comments.
vm_map.c
1254

I think the type should be vm_size_t but I see that I myself used it inconsistently.

This revision is now accepted and ready to land.May 22 2019, 5:35 PM
Closed by commit rS348115: Passing a parameter to vm_map_entry_resize_free that describes the (authored by dougm). · Explain WhyMay 22 2019, 5:41 PM
This revision was automatically updated to reflect the committed changes.
dougm marked an inline comment as done.
Herald added a subscriber: imp. · View Herald TranscriptMay 22 2019, 5:41 PM

Revision Contents
Changeset List

PathSize
23 lines

Diff 57703

View Options

vm_map.c

Loading...