Page MenuHomeFreeBSD
Differential D2668

Include libi386.h to silence the clang warning of implicit declaration of functions biospci_*.
ClosedPublic
Actions

Authored by araujo on May 29 2015, 4:18 AM.
Tags
None
Referenced Files
F159856829: D2668.diff
Thu, Jun 18, 8:41 PM
F159846523: D2668.id5767.diff
Thu, Jun 18, 6:21 PM
F159846494: D2668.id.diff
Thu, Jun 18, 6:21 PM
F159845588: D2668.id6014.diff
Thu, Jun 18, 6:07 PM
F159811024: D2668.diff
Thu, Jun 18, 12:13 PM
Unknown Object (File)
Sat, Jun 6, 9:40 AM
Unknown Object (File)
Fri, Jun 5, 8:21 PM
Unknown Object (File)
Fri, Jun 5, 7:34 PM
View All 82 Files
Subscribers
imp

Details

Reviewers
• rodrigc
imp
Commits
rS284116: Include header libi386.h to silence the clang warning of implicit declaration
Summary

Those biospci_* function are prototyped on: sys/boot/i386/libi386/libi386.h

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

araujo updated this revision to Diff 5767.May 29 2015, 4:18 AM
araujo retitled this revision from to Include libi386.h to silence the clang warning of implicit declaration of functions biospci_*..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added reviewers: imp, • rodrigc.
Herald added a subscriber: imp. · View Herald TranscriptMay 29 2015, 4:18 AM
• rodrigc accepted this revision.May 31 2015, 5:43 AM
• rodrigc edited edge metadata.

Looks OK, but double check that after this change
the loader still works and the system can boot.

This revision is now accepted and ready to land.May 31 2015, 5:43 AM
Closed by commit rS284116: Include header libi386.h to silence the clang warning of implicit declaration (authored by araujo). · Explain WhyJun 7 2015, 2:21 PM
This revision was automatically updated to reflect the committed changes.
araujo mentioned this in rS284116: Include header libi386.h to silence the clang warning of implicit declaration.

Revision Contents
Changeset List

PathSize
sys/
boot/
ficl/
1 line

Diff 5767

View Options

sys/boot/ficl/loader.c

Loading...