Page MenuHomeFreeBSD

netdump: Don't store sensitive key data we don't need
ClosedPublic

Authored by cem on May 10 2019, 8:35 PM.
Tags
None
Referenced Files
F167145415: D20233.id57292.diff
Wed, Aug 19, 11:39 AM
F167130508: D20233.id57292.diff
Wed, Aug 19, 8:48 AM
F167049068: D20233.id57287.diff
Tue, Aug 18, 7:59 PM
Unknown Object (File)
Tue, Aug 18, 10:54 AM
Unknown Object (File)
Mon, Aug 17, 1:17 PM
Unknown Object (File)
Sun, Aug 16, 7:24 PM
Unknown Object (File)
Thu, Aug 13, 8:40 PM
Unknown Object (File)
Tue, Aug 11, 12:28 AM
Subscribers

Details

Summary

The diocskerneldump_arg and netdump_conf (with embedded diocskerneldump_arg)
before it were copied in whole to the global nd_conf variable. After EKCD,
the diocskerneldump_arg contains sensitive key material. Before this
revision, de-configuring netdump would not remove the the key material from
global nd_conf.

Netdump doesn't have any use for the key data (that is handled in the core
dumper code), so just don't store it.

Unfortunately, I think this dates to the initial import of netdump in
r333283.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24191
Build 23034: arc lint + arc unit