Page MenuHomeFreeBSD

netdump: Don't store sensitive key data we don't need
ClosedPublic

Authored by cem on May 10 2019, 8:35 PM.
Tags
None
Referenced Files
F140627510: D20233.diff
Fri, Dec 26, 3:27 AM
Unknown Object (File)
Wed, Dec 17, 7:55 PM
Unknown Object (File)
Sat, Dec 13, 7:00 PM
Unknown Object (File)
Fri, Dec 12, 11:14 AM
Unknown Object (File)
Mon, Dec 8, 10:04 PM
Unknown Object (File)
Thu, Nov 27, 6:02 PM
Unknown Object (File)
Thu, Nov 27, 10:32 AM
Unknown Object (File)
Thu, Nov 27, 8:42 AM
Subscribers

Details

Summary

The diocskerneldump_arg and netdump_conf (with embedded diocskerneldump_arg)
before it were copied in whole to the global nd_conf variable. After EKCD,
the diocskerneldump_arg contains sensitive key material. Before this
revision, de-configuring netdump would not remove the the key material from
global nd_conf.

Netdump doesn't have any use for the key data (that is handled in the core
dumper code), so just don't store it.

Unfortunately, I think this dates to the initial import of netdump in
r333283.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24191
Build 23034: arc lint + arc unit