Page MenuHomeFreeBSD
Differential D20231

Clarify a mysterious expression
ClosedPublic
Actions

Authored by dougm on May 10 2019, 6:47 PM.
Tags
None
Referenced Files
F169973677: D20231.id.diff
Thu, Sep 3, 3:47 AM
Unknown Object (File)
Wed, Sep 2, 2:31 PM
Unknown Object (File)
Tue, Sep 1, 10:14 AM
Unknown Object (File)
Tue, Sep 1, 3:49 AM
Unknown Object (File)
Tue, Sep 1, 2:41 AM
Unknown Object (File)
Tue, Sep 1, 1:44 AM
Unknown Object (File)
Mon, Aug 31, 7:17 PM
Unknown Object (File)
Mon, Aug 31, 2:38 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rS347464: Replace the expression "-mask & ~mask" with a function call that does
Summary

Replace the expression "-mask & ~mask" with a function call that does the same thing, but is commented so that it might be better understood.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm created this revision.May 10 2019, 6:47 PM
kib accepted this revision.May 10 2019, 7:01 PM

No need to resend for this style nit.

subr_blist.c
653 ↗(On Diff #57282)

There should be a blank line after the '{' if no locals are declared.

This revision is now accepted and ready to land.May 10 2019, 7:01 PM
Closed by commit rS347464: Replace the expression "-mask & ~mask" with a function call that does (authored by dougm). · Explain WhyMay 10 2019, 7:55 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 10 2019, 7:55 PM

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
15 lines

Diff 57285

View Options

head/sys/kern/subr_blist.c

Loading...