Fix tests after rS347207
ClosedPublic
Actions

Authored by lwhsu on May 7 2019, 8:35 PM.

Details

Reviewers

phil

Commits

rS347359: Fix expected output after r347207

Summary

The new test cases added in rS347207 are failing in the CI system because of the output on stderr doesn't match:

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/11088/testReport/

I'm not 100% sure it's better to fix the saved output or the test code, but the test code modification is newer so I assume it's intended. Anyway, it's more like a style issue to me.

Test Plan

cd /usr/tests/lib/libxo && kyua test

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lwhsu created this revision.May 7 2019, 8:35 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 7 2019, 8:35 PM

Harbormaster completed remote builds in B24140: Diff 57146.May 7 2019, 8:35 PM

@phil or do you want me to have a PR in github?

Strange error; libtool related. On some platforms it seems to remove the ".test" extension. I'll add a fix to libxo to force removal of the extension (using xo_program() to set it to the basename), but for now, the fix here will be fine.

Are there instructions for how to test my particular component under kyua? Is it just "cd /usr/tests/lib/libxo && kyua test"?

Thanks,
Phil

This revision is now accepted and ready to land.May 7 2019, 9:09 PM

In D20188#434976, @phil wrote:

Strange error; libtool related. On some platforms it seems to remove the ".test" extension. I'll add a fix to libxo to force removal of the extension (using xo_program() to set it to the basename), but for now, the fix here will be fine.

Thanks!

Are there instructions for how to test my particular component under kyua? Is it just "cd /usr/tests/lib/libxo && kyua test"?

Yes, if you don't have kyua on your system, please install kyua package from pkg. libxo tests seems doesn't have other external dependencies so it should be fine.
Also please check kyua(1) for more information, you probably want to use kyua-debug(1) to execute a single test.

In D20188#434993, @lwhsu wrote:

In D20188#434976, @phil wrote:

Strange error; libtool related. On some platforms it seems to remove the ".test" extension. I'll add a fix to libxo to force removal of the extension (using xo_program() to set it to the basename), but for now, the fix here will be fine.

Thanks!