Add devel/zanata-platform: Zanata is a web-based translation platform Zanata is a web-based translation platform for managing localization projects. Localization (L10n) is the process of translating software or documentation into different languages. Zanata platform is designed for translators, content creators and developers to manage localization projects. WWW: http://zanata.org/ #Reviewed by: #Differential Revision: XXX
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Overall this looks good, please check my comments. Thanks for working on this!
| devel/zanata-platform/Makefile | ||
|---|---|---|
| 20 | Is this really a required dependency? I think could be an optional dependency: http://docs.zanata.org/en/release/user-guide/system-admin/configuration/installation/ | |
| 22 | It seems Zanata needs a mysql server to store data, but which is not "using" a mysql server. In other words, Zanata and mysql can be installed on different machines. Also, it seems we already pull in the mysql connector so there it doesn't need pull in mysql-client, either. | |
| 85 | Having this file with weak default password in the installation makes me very nervous, can we at least just use a pkg-message to some (other) documents to guide users to initial the admin user data? | |
| devel/zanata-platform/files/admin-user-setup.sql | ||
| 1 ↗ | (On Diff #56426) | I hope this file can mot be included in this port, which is a very insecure default. |
| devel/zanata-platform/files/pkg-message.in | ||
| 29 | Perhaps we also need to guide user to edit /etc/rc.conf or use sysrc(8). | |
| devel/zanata-platform/pkg-plist | ||
| 5 | @sample? | |
Comment Actions
@lwhsu thanks for reviewing it, I'll do some tests and then update the review.
| devel/zanata-platform/Makefile | ||
|---|---|---|
| 20 | right, I'll change this | |
| 22 | ok, do you think it's worth to have another optional dependency or just a message about a database in the pkg-message? | |
| 85 | we can have another approach on this, defining a specific username as admin: advanced-configuration | |
| devel/zanata-platform/files/admin-user-setup.sql | ||
| 1 ↗ | (On Diff #56426) | testing another approach |
| devel/zanata-platform/pkg-plist | ||
| 5 | wildfly already have a standalone.xml and standalone.xml.sample, I didn't mark it as @sample because of this, the user needs to copy it. | |
| devel/zanata-platform/Makefile | ||
|---|---|---|
| 22 | Can Zanata use other database? If it can only use mysql and we pulled in mysql connector, having a note to user to setup db connection settings should be fine. | |
| 85 | This looks better to me. I'm not sure using sql commands to create user is the official recommended way, if it really is, I think point to the document is enough. Having that .sql file installed on the system doesn't make much sense to me. | |
| devel/zanata-platform/pkg-plist | ||
| 5 | Ok, thanks for clarify. | |
Comment Actions
I tested the other approach suggested at configuration but the registration page is blocked for anonymous users, an admin needs to enable it.
More info here:
https://zanata.atlassian.net/browse/ZNTA-2083
https://zanata.atlassian.net/browse/ZNTA-1626
So I removed the .sql and added some notes in the pkg-message about this step.
Added rc.conf instructions.
Removed MySQL dependency and Clamav is now optional.
Comment Actions
I haven't had time to setup a server to test myself, but this port looks good to me. Thanks for the work!
| devel/zanata-platform/Makefile | ||
|---|---|---|
| 10 | Both files are versionned, this is probably not needed. | |
| 37 | any reason the default is almost the oldest possible version ? | |
| devel/zanata-platform/files/pkg-message.in | ||
| 3–44 | This file is really, really, really too long, nobody will ever read it (and probably never see it either). All this should probably be removed, keep only the link, it probably contains all of this. | |
| devel/zanata-platform/Makefile | ||
|---|---|---|
| 10 | right, I'll remove it. | |
| 37 | All Zanatta installations and instructions that I saw are using wildfly 9.X or 10.X. Their official container is using 10.X, see here, so I presumed that is safe to use the same version as default. | |
| devel/zanata-platform/files/pkg-message.in | ||
| 3–44 | The instructions are fragmented, we don't have a single link for it. What about removing this from pkg-message and install instructions into DATADIR? And inform users about it in the pkg-message? | |
| devel/zanata-platform/files/pkg-message.in | ||
|---|---|---|
| 3–44 | While I feel it's fine to have all these in pkg-message, how about this: let's put these instructions on wiki and put the link here? | |
| devel/zanata-platform/files/pkg-message.in | ||
|---|---|---|
| 3–44 | For me it's fine. We can copy Jenkins structure and insert a Install page: | |
| devel/zanata-platform/files/pkg-message.in | ||
|---|---|---|
| 3–44 | I think it's fine. | |