Add WebRTC support to www/qt5-webengine. The patches were again taken from www/chromium.
Related PR: 236915
Details
Details
- poudriere on 11.2-RELEASE amd64 -> OK (builds for the other releases are still running at the moment)
- Runtime test on https://test.webrtc.org/ didn't cause a crash as it was the case without the patches.
- Needs some more torough testing with typical use-cases. Testers are welcome!
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 23753 Build 22709: arc lint + arc unit
Event Timeline
| www/qt5-webengine/Makefile | ||
|---|---|---|
| 10–11 | Can you remove this comment? | |
Comment Actions
Removed the comment in the Makefile regarding WebRTC and updated the date in UPDATING.
Comment Actions
I tested the patch and it builds fine for me (12.0-STABLE r347145 amd64).
I could not complete the runtime test https://test.webrtc.org/ because I disabled INET6 on my system, so that the tests do not go through that step. Microphone works fine, camera does not but I never used it with any software so I can not say that it is WebRTC's fault. UDP and TCP work.
I thought getting WebRTC to work would have solved bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237277 about videos being reproduced with wrong colors (see comment 5, more precisely the link https://wiki.qt.io/QtWebEngine/VideoAcceleration ), however it is not fixed for me on falkon. Maybe this could be investigated a bit.
If, on the contrary, WebRTC has nothing to do with the bug, then the patch is fine for me.
Comment Actions
I change my status revision to approved: it is unsure if the bug I referenced depends on webrtc and, if it does, it can be dealt with another time.