Page MenuHomeFreeBSD
Differential D19829

Write string constant differently to improve readability.
ClosedPublic
Actions

Authored by delphij on Apr 5 2019, 6:45 AM.
Tags
None
Referenced Files
F106676415: D19829.id55873.diff
Fri, Jan 3, 6:13 PM
F106675271: D19829.id55833.diff
Fri, Jan 3, 5:56 PM
Unknown Object (File)
Nov 30 2024, 5:02 PM
Unknown Object (File)
Nov 7 2024, 4:54 PM
Unknown Object (File)
Oct 19 2024, 12:35 PM
Unknown Object (File)
Oct 19 2024, 1:59 AM
Unknown Object (File)
Oct 7 2024, 6:39 AM
Unknown Object (File)
Oct 6 2024, 10:37 PM
View All 56 Files
Subscribers
emaste
imp

Details

Reviewers
rgrimes
kevlo
pgj
emaste
Commits
rS345976: Write string constant differently to improve readability.
Summary

Write string constant differently to improve readability.

Test Plan

test with previous test cases

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23532
Build 22536: arc lint + arc unit

Event Timeline

delphij created this revision.Apr 5 2019, 6:45 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 5 2019, 6:45 AM
Harbormaster completed remote builds in B23532: Diff 55833.Apr 5 2019, 6:45 AM
rgrimes accepted this revision.Apr 5 2019, 8:15 AM

Thank you, that is 100x clearer as to what is in the constant

This revision is now accepted and ready to land.Apr 5 2019, 8:15 AM
emaste accepted this revision.Apr 5 2019, 8:25 PM
emaste added a subscriber: emaste.

This LGTM as long as compilers or static analyzers don't try to "helpfully" warn that the string does not fit or will not be null terminated.

Closed by commit rS345976: Write string constant differently to improve readability. (authored by delphij). · Explain WhyApr 6 2019, 3:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
fsck_msdosfs/
6 lines

Diff 55833

View Options

sbin/fsck_msdosfs/dir.c

Loading...